Re: [9front] [Patch] ndb/dns: DNSKEY and OPT RR types

[cinap_lenrek@felloff.net]

> Are your concerns regarding the caching the fact that opt RR's coming from upstream would be cached?

I'm concerned because theres some logic that checks
if the answer section is empty (msg->ar == nil).

The current code *does* some filtering on the answers
to avoid cache poisoning or caching unknown record
types.

But i dont want to bet on it that it will filter
hacks like Topt records.

I'd rather keep the opt records separate. One thing
less to worry about. No accidents.

> I agree, I will fix that in a revised patch if this behavior is still desired.

Thanks.

> If this whole EDNS stuff is undesired I can rip that part of the patch out, 

No, this is good work. But i agree that it would be better
as separate patches.

> but still think the code should catch the Tdnskey RR's, 

Yes, absolutely.

> as having those get caught in the default case was causing some
> parsing issues(or perhaps there is a another nice way of handling
> that, I am not sure)
>
> Thanks,
> Moody

--
cinap