9front - general discussion about 9front
 help / color / mirror / Atom feed
From: fulton@fulton.software
To: 9front@9front.org
Subject: Re: [9front] [PATCH] sha3 but fixed the code style
Date: Wed, 02 Jun 2021 14:04:26 -0700	[thread overview]
Message-ID: <357AE7E5832A1E6B7B2BF01C31A5FD11@fulton.software> (raw)
In-Reply-To: <81A58E6C8B19C6A43FC236CFCED33CE5@felloff.net>

I did attribute the authors in my first post email post, that email never went through and I should have re-attributed the author

https://github.com/mjosaarinen/tiny_sha3

> - sha3() needs to return nil on final run. 
- I'll fix that

>note, that this also will not work on big endian machines. you can
>try this with the mips instruction emulator vi(1).
I don't know how much I can do about that, but I'll look in to it.

>byte-by-byte xor is stupid.

I don't love it either, but I in this case it may be the best way to get it working, but I can change it.

>sha3_keccakf() seems more than sub-optimal

i'll rewrite it.

--
Fulton fulton.software!fulton

  parent reply	other threads:[~2021-06-03 17:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-31 16:00 fulton
2021-06-01 12:46 ` cinap_lenrek
2021-06-01 15:09   ` fulton
2021-06-02 12:16     ` cinap_lenrek
2021-06-01 19:51   ` fulton
2021-06-02 12:15     ` cinap_lenrek
2021-06-02 13:46       ` kemal
2021-06-02 14:16         ` kemal
2021-06-03  1:30           ` ori
2021-06-03 16:56           ` fulton
2021-06-02 14:45         ` cinap_lenrek
2021-06-03 15:24         ` fulton
2021-06-02 21:04       ` fulton [this message]
2021-06-03 20:28         ` hiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=357AE7E5832A1E6B7B2BF01C31A5FD11@fulton.software \
    --to=fulton@fulton.software \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).