From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=DATE_IN_PAST_12_24
	autolearn=no autolearn_force=no version=3.4.4
Received: (qmail 10365 invoked from network); 3 Jun 2021 17:06:23 -0000
Received: from 1ess.inri.net (216.126.196.35)
  by inbox.vuxu.org with ESMTPUTF8; 3 Jun 2021 17:06:23 -0000
Received: from 149.28.13.84 ([149.28.13.84]) by 1ess; Thu Jun  3 12:58:03 -0400 2021
Message-ID: <357AE7E5832A1E6B7B2BF01C31A5FD11@fulton.software>
Date: Wed, 02 Jun 2021 14:04:26 -0700
From: fulton@fulton.software
To: 9front@9front.org
In-Reply-To: <81A58E6C8B19C6A43FC236CFCED33CE5@felloff.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: polling enhancement factory-scale standard general-purpose solution 
Subject: Re: [9front] [PATCH] sha3 but fixed the code style
Reply-To: 9front@9front.org
Precedence: bulk

I did attribute the authors in my first post email post, that email never went through and I should have re-attributed the author

https://github.com/mjosaarinen/tiny_sha3

> - sha3() needs to return nil on final run. 
- I'll fix that

>note, that this also will not work on big endian machines. you can
>try this with the mips instruction emulator vi(1).
I don't know how much I can do about that, but I'll look in to it.

>byte-by-byte xor is stupid.

I don't love it either, but I in this case it may be the best way to get it working, but I can change it.

>sha3_keccakf() seems more than sub-optimal

i'll rewrite it.

--
Fulton fulton.software!fulton