From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 17864 invoked from network); 13 Feb 2021 22:30:05 -0000
Received: from 1ess.inri.net (216.126.196.35)
  by inbox.vuxu.org with ESMTPUTF8; 13 Feb 2021 22:30:05 -0000
Received: from mimir.eigenstate.org ([206.124.132.107]) by 1ess; Sat Feb 13 15:06:36 -0500 2021
Received: from abbatoir.fios-router.home (pool-74-101-2-6.nycmny.fios.verizon.net [74.101.2.6])
	by mimir.eigenstate.org (OpenSMTPD) with ESMTPSA id b697df85 (TLSv1.2:ECDHE-RSA-AES256-SHA:256:NO)
	for <9front@9front.org>;
	Sat, 13 Feb 2021 12:06:24 -0800 (PST)
Message-ID: <359D5A90DCD0DE4120049A0064989632@eigenstate.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
To: 9front@9front.org
Date: Sat, 13 Feb 2021 12:06:22 -0800
From: ori@eigenstate.org
In-Reply-To: <2d5ba311e52f92be0cd5574c95bab7aa@quintile.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: managed element hosting 
Subject: Re: [9front] sam input line length limits
Reply-To: 9front@9front.org
Precedence: bulk

Quoth Steve Simon <steve@quintile.net>:
> Normally I would be very wary of changing sam it has served
> me well for many years, but I am with you on this one,
> it has bitten me in the past and its annoying.
> 
> Re the patch:
> 
> I am being pedantic, I know, but for completeness...
> free(c) should come before the test for s == nil,
> as it could lead to a memory leak. reordering the code
> fractionally fixes it.

Yep, it definitely should. Thanks for looking.
I'll actually *run* the code today, and see if
I missed anything.