From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
Received: (qmail 18781 invoked from network); 15 Mar 2022 09:17:56 -0000
Received: from 4ess.inri.net (216.126.196.42)
  by inbox.vuxu.org with ESMTPUTF8; 15 Mar 2022 09:17:56 -0000
Received: from mail.9lab.org ([168.119.8.41]) by 4ess; Tue Mar 15 04:34:33 -0400 2022
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9lab.org; s=20210803;
	t=1647333264;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:  in-reply-to:in-reply-to;
	bh=nv+tRAfngavKEF0BYi81vgBovnfZnW6HIdVb8/dIBBk=;
	b=nSn+gCWDG3eV3P39f3YeFJ2Rjw64C4/vhNnSkyKiTAkQyZK1PEKD0YY81nbz0vqlNQxz+b
	G9z3zGsnhxzlFWLzVgQnSwxcQRgbhCcq3kP0cpTfPA8wqQRTtjN84/ju+JxDkhbEAVFPXg
	WTqaeEexnwLqJthhVzre5F+O+ouuGOQ=
Received: from pjw (host-185-64-155-70.ecsnet.at [185.64.155.70])
	by mail.9lab.org (OpenSMTPD) with ESMTPSA id cb119005 (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO);
	Tue, 15 Mar 2022 09:34:24 +0100 (CET)
Message-ID: <36B9278E3AE1F076829A180A50B0B401@9lab.org>
To: 9front@9front.org
CC: igor@9lab.org
Date: Tue, 15 Mar 2022 09:34:22 +0100
From: igor@9lab.org
In-Reply-To: <F7001DE6-2C7C-417F-9E66-F0CE26B2D94E@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: transactional scale-out database 
Subject: Re: [9front] acme hides top windows after loading a dump file
Reply-To: 9front@9front.org
Precedence: bulk

To reliably reproduce the behaviour the window that acme is started in
requires a certain size:

  % window -dx 913 -dy 606  'acme -l /tmp/test.dump'

Tested the fix; will push it later today.

Thanks for the report and the patch!

Quoth Xiao-Yong Jin <meta.jxy@gmail.com>:
> When loading a dump file contains a window with an only tag line, acme hides that window.
> Here is a simple dump file reproduces this issue.
> 
> #### dump file begins ####
> /tmp
> /lib/font/bit/pelm/unicode.8.font
> /lib/font/bit/pelm/unicode.8.font
>           0
> f          0           5         175         175           1 
>           5          40         175           1           0 /sys/src/cmd/acme/ Del Snarf Get | Look 
> f          0           4         330         330           3 
>           4          27         330           1           0 /tmp/ Del Snarf Get | Look 
> #### dump file ends ####
> 
> This issue is introduced in commit 47b7dc5ccd77bc247ab15cfab3a7a8f955771c70
> 
> Reinstate two lines as the patch below fix the issue.
> 
> diff ca313087c1715a0331a58c01ad104632d366f057 uncommitted
> --- a/sys/src/cmd/acme/wind.c
> +++ b/sys/src/cmd/acme/wind.c
> @@ -188,6 +188,8 @@
>                 w->taglines = wintaglines(w, r);
>                 r1.max.y = min(r.max.y, r1.min.y + w->taglines*font->height);
>         }
> +       if(Dy(r1) < font->height)
> +               r1.max.y = r1.min.y+font->height;
>         /* If needed, resize & redraw tag. */
>         y = r1.max.y;
>         if(!safe || !w->tagsafe || !eqrect(w->tag.r, r1)){
>