[9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt

[9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt

[Stanley Lieber]

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: 20230524_233032.jpg --]
[-- Type: image/jpeg, Size: 1551654 bytes --]

Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt

[Stanley Lieber]

On May 24, 2023 11:31:33 PM EDT, Stanley Lieber <sl@stanleylieber.com> wrote:
>
http://plan9.stanleylieber.com/hardware/thinkpad/x1/yoga/g3/sysinfo

Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt

[unobe]

Quoth Stanley Lieber <sl@stanleylieber.com>:
> On May 24, 2023 11:31:33 PM EDT, Stanley Lieber <sl@stanleylieber.com> wrote:
> >
> http://plan9.stanleylieber.com/hardware/thinkpad/x1/yoga/g3/sysinfo

So the latest code (do you have a specific commit to reference) works
fine, until you try to fshalt?

Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt

[Stanley Lieber]

On May 25, 2023 12:47:45 AM EDT, unobe@cpan.org wrote:
>Quoth Stanley Lieber <sl@stanleylieber.com>:
>> On May 24, 2023 11:31:33 PM EDT, Stanley Lieber <sl@stanleylieber.com> wrote:
>> >
>> http://plan9.stanleylieber.com/hardware/thinkpad/x1/yoga/g3/sysinfo
>
>So the latest code (do you have a specific commit to reference) works
>fine, until you try to fshalt?
>
>

yes, everything is fine until fshalt. the crash happens on every fshalt.

i did sysupdate, rebuilt the system, installed the kernel, and tested shortly before sending the original mail. no new commits since then.

sl

Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt

[mia soweli]

the stack trace attached seems to have been truncated,
and it's not enough to see what's being freed.

could you upload it somewhere so i can get the full trace?

thanks

Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt

[Stanley Lieber]

On May 25, 2023 7:42:12 AM EDT, mia soweli <inbox@tachibana-labs.org> wrote:
>the stack trace attached seems to have been truncated,
>and it's not enough to see what's being freed.
>
>could you upload it somewhere so i can get the full trace?
>
>thanks
>
>

http://img.stanleylieber.com/src/23771/img/1685022656.jpg

sl

Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt

[Sigrid Solveig Haflínudóttir]

the bug is in sdram.c, it uses xalloc for sddev allocation, but
devsd.c calls free on it. should be an easy fix I guess.

Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt

[sl]

> the bug is in sdram.c, it uses xalloc for sddev allocation, but
> devsd.c calls free on it. should be an easy fix I guess.

i wonder why this never triggered until just now.  i've been running
9front on this machine all year.

sl

Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt

[Sigrid Solveig Haflínudóttir]

It's because I added nvme shutdown via fshalt, and apparently shutting down *ram* disks uncovered this bug. Because sdram seems to be only present on pc and pc64 (read: none that I have here) I haven't noticed it before pushing my change. I think you can just replace xalloc back with malloc in sdram.c.
Sorry.

On May 26, 2023 2:50:16 AM GMT+02:00, sl@stanleylieber.com wrote:
>> the bug is in sdram.c, it uses xalloc for sddev allocation, but
>> devsd.c calls free on it. should be an easy fix I guess.
>
>i wonder why this never triggered until just now.  i've been running
>9front on this machine all year.
>
>sl

Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt

[sl]

> It's because I added nvme shutdown via fshalt, and apparently shutting
> down *ram* disks uncovered this bug.  Because sdram seems to be only
> present on pc and pc64 (read: none that I have here) I haven't noticed
> it before pushing my change.  I think you can just replace xalloc back
> with malloc in sdram.c.  Sorry.

no problem at all. s/xalloc/malloc/ in port/sdram.c fixes the issue for
my machine.

anybody else seen this?

sl

Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt

[Tobias Heinicke]

Can confirm; I\b\b that is I was able to reproduce the crash and chain\b\bnging from xalloc to malloc in port/sdram.c makes it disappear again.

--
Tobias Heinicke

Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt

[Jacob Moody]

On 5/26/23 09:36, Tobias Heinicke wrote:
> Can confirm; I\b\b that is I was able to reproduce the crash and chain\b\bnging from xalloc to malloc in port/sdram.c makes it disappear again.
> 
> --
> Tobias Heinicke

This fix is now committed as well.

Re: [9front] latest code crashes thinkpad x1 yoga 3rd gen on fshalt

[Stanley Lieber]

On May 26, 2023 11:42:04 AM EDT, Jacob Moody <moody@mail.posixcafe.org> wrote:
>On 5/26/23 09:36, Tobias Heinicke wrote:
>> Can confirm; I\b\b that is I was able to reproduce the crash and chain\b\bnging from xalloc to malloc in port/sdram.c makes it disappear again.
>> 
>> --
>> Tobias Heinicke
>
>This fix is now committed as well.
>
>
>

thanks, sigrid and moody!

sl