From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 12720 invoked from network); 28 Sep 2023 07:03:13 -0000 Received: from 9front.inri.net (168.235.81.73) by inbox.vuxu.org with ESMTPUTF8; 28 Sep 2023 07:03:13 -0000 Received: from pb-smtp2.pobox.com ([64.147.108.71]) by 9front; Thu Sep 28 03:01:07 -0400 2023 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 8BD5C1A14C3 for <9front@9front.org>; Thu, 28 Sep 2023 03:01:07 -0400 (EDT) (envelope-from unobe@cpan.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=message-id :to:subject:date:from:in-reply-to:mime-version:content-type :content-transfer-encoding; s=sasl; bh=huixJxjN0ksAogYjdq+ZVO2+N YU6byMf4mqu6kB/jZs=; b=gEzN995y7lIn/ZxQk7CYZjKuGvOXt2rUkOTLCh7ts QTY+0+FXZ6VzB0suqAHbkElZwRsV2xmBbQhAUx/I/89t1T0yWtw5xBoCJeajpFK+ IJPnEAjlFaGmroUvRPJ73z4MFt7r0s3xCu8CtafSdHD2PXRfxNRxFn1vE4ieA9Y7 Gk= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 6EE121A14C2 for <9front@9front.org>; Thu, 28 Sep 2023 03:01:07 -0400 (EDT) (envelope-from unobe@cpan.org) Received: from strider.localdomain (unknown [75.237.252.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id DE91C1A14BB for <9front@9front.org>; Thu, 28 Sep 2023 03:01:05 -0400 (EDT) (envelope-from unobe@cpan.org) Message-ID: <3AD63E8753BA9DDE2027D29FD2C81A04@smtp.pobox.com> To: 9front@9front.org Date: Thu, 28 Sep 2023 00:01:03 -0700 From: unobe@cpan.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Pobox-Relay-ID: CB499400-5DCC-11EE-9F86-25B3960A682E-09620299!pb-smtp2.pobox.com List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: just-in-time storage AJAX markup CSS solution Subject: Re: [9front] [PATCH 3/6] nusb/ptp: add mention to nusb man page and fix implementation per spec to start with transaction id 1, not 0. Reply-To: 9front@9front.org Precedence: bulk The transaction id is meant to be 0, not 1, per the spec (and what the patch shows): slipped up on the first line of the commit message. Quoth Romano : > > Apple iPhones can now be used to transfer images. There is still an issue with the iPhone permission, wherein an actor has to be pretty quick on the trigger to Allow the connection from the iPhone side, but that would require a pause somewhere in the handshake that I did not have time to look into further. This patch at least allows the connection to succeed when permitted. > --- > diff c9c5d6455a6502ffb0f5490d5602396852261f4c 755ac2c11ce134f76d83a2a42edb07a6304d1de8 > --- a/sys/man/4/nusb > +++ b/sys/man/4/nusb > @@ -194,6 +194,10 @@ > The > .B ctl > file supplies the device geometry and partitions when read. > +.I Ptp > +configures and exposes a camera's (and often a mobile > +device's) storage to allow transferring data via the > +Picture Transfer Protocol (PTP). > .SS Ethernet > .I Ether > handles USB ethernet devices. The file system provided is > --- a/sys/src/cmd/nusb/ptp/ptp.c > +++ b/sys/src/cmd/nusb/ptp/ptp.c > @@ -75,9 +75,8 @@ > > static int debug = 0; > static ulong time0; > -static int maxpacket = 64; > -static int sessionId = 1; > -static int transId = 1; > +static int sessionId; > +static int transId; > > static Node **nodes; > static int nnodes; > @@ -556,7 +555,7 @@ > } > > /* > - * another proc migh'v come in and done it for us, > + * another proc might've come in and done it for us, > * so check the cache again. > */ > if(y = cachednode(path, &f)) > @@ -1048,6 +1047,7 @@ > sendp(iochan, ioproc()); > > sessionId = getpid(); > + transId = 0; > if(ptprpc(nil, OpenSession, 1, sessionId) < 0) > sysfatal("open session: %r"); > > >