9front - general discussion about 9front
 help / color / mirror / Atom feed
From: cinap_lenrek@felloff.net
To: 9front@9front.org
Subject: Re: [9front] Patch to bring 9front venti libventi up to date with 9legacy
Date: Wed, 19 Sep 2018 11:11:06 +0200	[thread overview]
Message-ID: <3C0FAC2A693E7948ADA3371272FB9B78@felloff.net> (raw)
In-Reply-To: CADmmOS9HSacznjjot3wFDQD+3jDjave_M=ROnY5o7k4wPn=D_Q@mail.gmail.com

what are these changes for? VtEntry oe seems to be unused?

diff -r a3522064f5dc sys/src/libventi/file.c
--- a/sys/src/libventi/file.c	Wed Sep 19 01:11:49 2018 +0200
+++ b/sys/src/libventi/file.c	Tue Sep 18 19:30:23 2018 -0500
@@ -503,6 +503,7 @@
 	VtBlock *b;
 	int type;
 	uchar *score;
+	VtEntry oe;
 
 	switch(p->type){
 	case VtDataType:
@@ -530,6 +531,8 @@
 
 	if(vtglobaltolocal(b->score) != NilBlock)
 		return b;
+	
+	oe = *e;
 
 	/*
 	 * Copy on write.
@@ -597,6 +600,7 @@
 shrinkdepth(VtFile *r, VtBlock *p, VtEntry *e, int depth)
 {
 	VtBlock *b, *nb, *ob, *rb;
+	VtEntry oe;
 
 	assert(ISLOCKED(r));
 	assert(depth <= VtPointerDepth);
@@ -604,6 +608,12 @@
 	rb = vtcacheglobal(r->c, e->score, e->type);
 	if(rb == nil)
 		return -1;
+	
+	/*
+	 * Walk down to the new root block.
+	 * We may stop early, but something is better than nothing.
+	 */
+	oe = *e;
 
 	ob = nil;
 	b = rb;

--
cinap


             reply	other threads:[~2018-09-19  9:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-19  9:11 cinap_lenrek [this message]
2018-09-19 10:26 ` hiro
  -- strict thread matches above, loose matches on Subject: below --
2018-09-19 12:29 cinap_lenrek
2018-09-19  9:08 cinap_lenrek
2018-09-18 23:41 cinap_lenrek
2018-09-18 23:36 cinap_lenrek
2018-09-19  0:34 ` Sean Hinchee
2018-09-19  6:55   ` hiro
2018-09-19  7:00     ` hiro
2018-09-17 21:49 cinap_lenrek
2018-09-18 23:22 ` Sean Hinchee
2018-09-17 20:54 Sean Hinchee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C0FAC2A693E7948ADA3371272FB9B78@felloff.net \
    --to=cinap_lenrek@felloff.net \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).