From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.4 Received: (qmail 4456 invoked from network); 16 Nov 2022 02:59:23 -0000 Received: from 9front.inri.net (168.235.81.73) by inbox.vuxu.org with ESMTPUTF8; 16 Nov 2022 02:59:23 -0000 Received: from mail-pf1-f177.google.com ([209.85.210.177]) by 9front; Tue Nov 15 21:57:37 -0500 2022 Received: by mail-pf1-f177.google.com with SMTP id y13so16210346pfp.7 for <9front@9front.org>; Tue, 15 Nov 2022 18:57:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mforney.org; s=google; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:references:from:subject:to:date:from:to:cc:subject:date :message-id:reply-to; bh=myuLbsyx1OycuMLp80S+/LaOKtPWkXeMRqG66zt6Ydk=; b=MzB+BxZiSkbYftSOkz0vNbKj8wrpB7WVKycDMYpSsKbEainoB4jRzRnzal3bTBAsa6 oa0KB4V46M1J840ayh3mbIOFwk2wSpWR547rj2/p7u2VJHW8N1v38f6vH/vf/+GULo5M V+LfF9MtIyp8/WL6+HetGxPY6AyBSa2dyiRvbD5CwQUASOjX0Ca+lEAxtnjwN/f4/CxJ 6bVVe4M867yj8D7LsY+1zj4LB9w6yOVlPnqTF7cVhGEnmMH8xqREUNRxKMEKXYSKslp9 UDz3fIGR0+Hr+B9RRcTFrP8seET3Ye+cByJ1EExcQpyg40XX3K/Y/cMQDdzUdCyydQP7 PMOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:references:from:subject:to:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=myuLbsyx1OycuMLp80S+/LaOKtPWkXeMRqG66zt6Ydk=; b=2BceCxBR06vtQxjzf0CRPbceIIafzgND0HsdYynyG1o1oQ2uyR9LA6hvpCGoFDWl0F pkO5c2tFF8tvnFpZ+3pzcNQRIebzjToC2JNkV7BFIYk4yZRyAKp1e7xJbVbzeDJCR3BH Cv4wkN4fuVwtU/BQrxr2+KbyQHAMj58yL8I2d8i+ezCKQg+Lnbl6txj+UGdBnaDDGeuS FgAMyjCc3uzxeLGWyURjoa1Lb+OHgZ+F+P8ypj19t+s8YcOgGYJG6FcZoR7vi/2BKyEJ gZnIuSu4T/4Z7QpcEiLGA+baFZyq6LoisifYiAfC0D2vdI2rPpqyzBL+cMilHA2CvGL6 vHvg== X-Gm-Message-State: ANoB5pm42xuYB+2Nlgi6Lgh98SH6RXKxtTSHrT1UbPgDldFugMgUy8d1 vx+t5oLX1JR0nVRqgGddL99TzXH7rNlV1RGijfw= X-Google-Smtp-Source: AA0mqf78lIt7b8NLCwkqcYPUXe1ULsrRZ5wxAFjv4hTMtp3/6rkPP7vw92S4dwQBX/5cnr5DQl0quw== X-Received: by 2002:a05:6a00:428a:b0:56e:8477:1add with SMTP id bx10-20020a056a00428a00b0056e84771addmr21350794pfb.13.1668567453878; Tue, 15 Nov 2022 18:57:33 -0800 (PST) Return-Path: Received: from localhost ([2601:647:6400:20b0:16dd:a9ff:fee7:6b79]) by smtp.gmail.com with ESMTPSA id p6-20020a63f446000000b0047079cb8875sm8534910pgk.42.2022.11.15.18.57.32 for <9front@9front.org> (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Nov 2022 18:57:32 -0800 (PST) Date: Tue, 15 Nov 2022 18:57:31 -0800 To: 9front@9front.org From: Michael Forney References: In-Reply-To: Message-Id: <3M903J9M0U8R4.2WW93NM7C4G44@mforney.org> User-Agent: mblaze/1.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: progressive proxy NoSQL WEB2.0 dependency app Subject: Re: [9front] [PATCH] tee: remove unused variable in Reply-To: 9front@9front.org Precedence: bulk Sigrid Solveig Hafl=C3=ADnud=C3=B3ttir wrote: > Your original patch looks wrong - git/import could > not apply it. Git/export is supposed to produce the > right thing. Although the patch isn't what you'd get with git/commit and git/export, I don't think anything is wrong with it apart from being a bit unconventional. We should be able to deal with it with our tools. There are two issues here: 1. The patch relies on standard filename detection behavior that our new patch implementation doesn't follow. There are plenty of patches in the wild like this, and I mentioned it in the `patch(1) filename detection thread` a while back. I have a local patch patch in my queue that fixes this. 2. git/import has no way to forward -p arguments to patch. git am has this, and it seems both useful and easy to add to git/import. With both of those fixed, git/import -p0 would do the trick.