9front - general discussion about 9front
 help / color / mirror / Atom feed
From: cinap_lenrek@felloff.net
To: 9front@9front.org
Subject: Re: [9front] upas/fs imap fixes and improvements.
Date: Wed, 20 Nov 2019 08:34:27 +0100	[thread overview]
Message-ID: <43C906E51D63F6E203EA1AE97241F24B@felloff.net> (raw)
In-Reply-To: 238BC74F09F7F7BC68774B3528388D5F@eigenstate.org

on first glance:

-			if(imap->nuid < imap->muid)
+			if(idx < imap->muid)
 				imap->f[imap->nuid].dates = l;

should be: imap->f[idx].dates = l instead?

+				memcpy(&imap->f[idx], &imap->f[idx + 1], imap->nmsg - idx - 1);

maybe use memmove() instead as source and dest overlap.

--
cinap


             reply	other threads:[~2019-11-20  7:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20  7:34 cinap_lenrek [this message]
2019-11-21  1:45 ori
2019-11-22 19:49 ori
2019-11-22 20:50 cinap_lenrek
2019-11-22 23:46 ori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43C906E51D63F6E203EA1AE97241F24B@felloff.net \
    --to=cinap_lenrek@felloff.net \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).