From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from duke.felloff.net ([216.126.196.34]) by ewsd; Wed Nov 20 02:34:37 EST 2019
Message-ID: <43C906E51D63F6E203EA1AE97241F24B@felloff.net>
Date: Wed, 20 Nov 2019 08:34:27 +0100
From: cinap_lenrek@felloff.net
To: 9front@9front.org
Subject: Re: [9front] upas/fs imap fixes and improvements.
In-Reply-To: 238BC74F09F7F7BC68774B3528388D5F@eigenstate.org
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: shared overflow-preventing method descriptor TOR polling engine 

on first glance:

-			if(imap->nuid < imap->muid)
+			if(idx < imap->muid)
 				imap->f[imap->nuid].dates = l;

should be: imap->f[idx].dates = l instead?

+				memcpy(&imap->f[idx], &imap->f[idx + 1], imap->nmsg - idx - 1);

maybe use memmove() instead as source and dest overlap.

--
cinap