9front - general discussion about 9front
 help / color / mirror / Atom feed
From: igor@9lab.org
To: 9front@9front.org
Cc: igor@9lab.org
Subject: Re: [9front] leak(1): document how to generate pool.$objtype.acid required for leak
Date: Fri, 05 Nov 2021 10:25:36 +0100	[thread overview]
Message-ID: <446B3BD09A21F87115EE471F66F195EE@9lab.org> (raw)
In-Reply-To: <YYThGW1qXUo+PhO0@beryllium.local>

[-- Attachment #1: Type: text/plain, Size: 1834 bytes --]

Quoth Humm <hummsmith42@gmail.com>:
> Quoth igor@9lab.org:
> >/sys/lib/acid/leak requires /sys/src/libc/port/pool.$objtype.acid
> >which is not present by default.
> >
> >The attached patch adds an acid target to /sys/src/libc/port/mkfile
> >that generates pool.$objtype.acid and refers to it in leak(1).
> 
> The new target is unnecessary, as %.acid in /sys/src/cmd/mksyslib can 
> generate pool.$objtype.acid already.

Thanks for pointing this out. That means the only thing
requiring modification is leak(1) by documenting how to
generate the acid file, namely like this:

 % cd /sys/src/libc/port && mk pool.$objtype.acid

Attached si anupdated patch to leak(1) only. Unless there
are any more comments I will merge this over the weekend.

<snip>
From: Igor Böhm <igor@9lab.org>
Date: Thu, 04 Nov 2021 23:11:56 +0000
Subject: [PATCH] leak(1): document how to generate pool.$objtype.acid

/sys/lib/acid/leak requires /sys/src/libc/port/pool.$objtype.acid
which is not present by default, describe how to generate it.

---
diff ca73f673473457152d6f1b2e9030495f8dec5c49 2c38083b6c34c72b5417f29dc6002aa445212ae5
--- a/sys/man/1/leak	Mon Nov  1 18:07:28 2021
+++ b/sys/man/1/leak	Fri Nov  5 00:11:56 2021
@@ -218,7 +218,17 @@
 .I kmem
 depend on the internal structure of the
 libc pool memory allocator (see 
-.IR pool (2)).
+.IR pool (2))
+and require
+.B /sys/src/libc/port/pool.$objtype.acid
+to be present and generated from
+.BR pool.c 
+as follows:
+.IP
+.EX
+% cd /sys/src/libc/port && mk pool.$objtype.acid
+.EE
+.PP
 Since the ANSI/POSIX environment uses a different
 allocator,
 .I leak
@@ -228,8 +238,5 @@
 is not speedy, and
 .I acidleak
 can consume more memory than the process(es) being examined.
-.PP
-These commands require
-.B /sys/src/libc/port/pool.acid
-to be present and generated from
-.BR pool.c .
+
+
</snap>

[-- Attachment #2: leak.patch --]
[-- Type: text/plain, Size: 1075 bytes --]

From: Igor Böhm <igor@9lab.org>
Date: Thu, 04 Nov 2021 23:11:56 +0000
Subject: [PATCH] leak(1): document how to generate pool.$objtype.acid

/sys/lib/acid/leak requires /sys/src/libc/port/pool.$objtype.acid
which is not present by default, describe how to generate it.

---
diff ca73f673473457152d6f1b2e9030495f8dec5c49 2c38083b6c34c72b5417f29dc6002aa445212ae5
--- a/sys/man/1/leak	Mon Nov  1 18:07:28 2021
+++ b/sys/man/1/leak	Fri Nov  5 00:11:56 2021
@@ -218,7 +218,17 @@
 .I kmem
 depend on the internal structure of the
 libc pool memory allocator (see 
-.IR pool (2)).
+.IR pool (2))
+and require
+.B /sys/src/libc/port/pool.$objtype.acid
+to be present and generated from
+.BR pool.c 
+as follows:
+.IP
+.EX
+% cd /sys/src/libc/port && mk pool.$objtype.acid
+.EE
+.PP
 Since the ANSI/POSIX environment uses a different
 allocator,
 .I leak
@@ -228,8 +238,5 @@
 is not speedy, and
 .I acidleak
 can consume more memory than the process(es) being examined.
-.PP
-These commands require
-.B /sys/src/libc/port/pool.acid
-to be present and generated from
-.BR pool.c .
+
+

      reply	other threads:[~2021-11-05 10:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04 23:31 igor
2021-11-05  7:45 ` Humm
2021-11-05  9:25   ` igor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=446B3BD09A21F87115EE471F66F195EE@9lab.org \
    --to=igor@9lab.org \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).