From: ori@eigenstate.org
To: 9front@9front.org
Subject: Re: [9front] [PATCH] vmx: fix PCI ID for virtio block devices
Date: Thu, 27 Jan 2022 11:39:52 -0500 [thread overview]
Message-ID: <466F2F1E14916A2CFC58165C44A6B35F@eigenstate.org> (raw)
In-Reply-To: <CED91D181EDA3797DE264668F1BC7091@arrow>
Quoth Michael Forney <mforney@mforney.org>:
>
> The transitional PCI device ID for block devices is 0x1001, and the
> virtio spec says that devices must have the transitional device ID or
> 0x1040 + the virtio device ID (2).
> ---
> diff 60adc40118dda2edf2a238d22d050a7bae5e0d66 950eab9262196472c5b086d1b33fadc9fc1c211b
> --- a/sys/src/cmd/vmx/virtio.c Sun Jan 23 13:33:58 2022
> +++ b/sys/src/cmd/vmx/virtio.c Mon Jan 24 15:48:13 2022
> @@ -792,7 +792,7 @@
>
> fd = open(fn, ORDWR);
> if(fd < 0) return -1;
> - d = mkviodev(0x1000, 0x018000, 2, 1);
> + d = mkviodev(0x1001, 0x018000, 2, 1);
> mkvioqueue(d, 32, viowakeup);
> d->io = vioblkio;
> d->blk.fd = fd;
>
read the spec, confirmed -- looks good to me, and
openbsd still boots in vmx.
thanks, pushed.
prev parent reply other threads:[~2022-01-27 16:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 23:48 Michael Forney
2022-01-27 16:39 ` ori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466F2F1E14916A2CFC58165C44A6B35F@eigenstate.org \
--to=ori@eigenstate.org \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).