From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 30625 invoked from network); 27 Jan 2022 16:49:40 -0000 Received: from 4ess.inri.net (216.126.196.42) by inbox.vuxu.org with ESMTPUTF8; 27 Jan 2022 16:49:40 -0000 Received: from mimir.eigenstate.org ([206.124.132.107]) by 4ess; Thu Jan 27 11:40:37 -0500 2022 Received: from abbatoir.myfiosgateway.com (pool-74-108-56-225.nycmny.fios.verizon.net [74.108.56.225]) by mimir.eigenstate.org (OpenSMTPD) with ESMTPSA id f0b37d96 (TLSv1.2:ECDHE-RSA-AES256-SHA:256:NO) for <9front@9front.org>; Thu, 27 Jan 2022 08:39:53 -0800 (PST) Message-ID: <466F2F1E14916A2CFC58165C44A6B35F@eigenstate.org> To: 9front@9front.org Date: Thu, 27 Jan 2022 11:39:52 -0500 From: ori@eigenstate.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: DOM-aware blockchain Subject: Re: [9front] [PATCH] vmx: fix PCI ID for virtio block devices Reply-To: 9front@9front.org Precedence: bulk Quoth Michael Forney : > > The transitional PCI device ID for block devices is 0x1001, and the > virtio spec says that devices must have the transitional device ID or > 0x1040 + the virtio device ID (2). > --- > diff 60adc40118dda2edf2a238d22d050a7bae5e0d66 950eab9262196472c5b086d1b33fadc9fc1c211b > --- a/sys/src/cmd/vmx/virtio.c Sun Jan 23 13:33:58 2022 > +++ b/sys/src/cmd/vmx/virtio.c Mon Jan 24 15:48:13 2022 > @@ -792,7 +792,7 @@ > > fd = open(fn, ORDWR); > if(fd < 0) return -1; > - d = mkviodev(0x1000, 0x018000, 2, 1); > + d = mkviodev(0x1001, 0x018000, 2, 1); > mkvioqueue(d, 32, viowakeup); > d->io = vioblkio; > d->blk.fd = fd; > read the spec, confirmed -- looks good to me, and openbsd still boots in vmx. thanks, pushed.