Re: [9front] ape/bsd: Enable setting the local address with bind

[ori@eigenstate.org]

Apologies for taking so long to respond. Life got busy, and
I forgot.

Quoth Benjamin Riefenstahl <b.riefenstahl@turtle-trading.net>:
> The current code ignores the address as passed to the BSD socket
> function bind().  It seems that that may not have been possible with
> earlier versions of the net API?  I discovered by reading the code and
> experimentation that this seems to work fine in the current net API, so
> this implements it for BSD sockets.
> 
> I removed some previous code that did not make sense to me, so you may
> want to check that I did not screw up.  What I mean is "bind *" in
> bind() and about "bind 0" in listen().
>
> The handling when ports < 0 are specified is not consistent yet.  Either
> we should normalize the ports to be at least 0, or we should return an
> error condition for ports < 0.

This looks like it's attempting (incorrectly?) to implement INADDR_ANY,
binding to any ip address. However, INADDR_ANY is 0:

	/sys/include/ape/netinet/in.h:98:
		#define	INADDR_ANY		(unsigned long)0x00000000

And I see no specification that describes what should be done with
negative ports in the sockets world, so I can only assume that this
is a bug. I don't think 'bind *' should be removed, since it seems
to me that it works as intended for binding to all addresses, but
the ape userspace for it is wrong.
 
> The documentation in the man page ip(3) for the control commands "bind"
> and "announce" does not mention the local address, should that be fixed,
> too?

Yes, that would be wonderful.