9front - general discussion about 9front
 help / color / mirror / Atom feed
From: mischief <mischief@offblast.org>
To: 9front@9front.org
Subject: [PATCH 8 of 8] tput: use iounit for reads, check sbrk return value
Date: Sun, 23 Aug 2015 16:49:18 -0700	[thread overview]
Message-ID: <4d2e0315f59bc5153bd4.1440373758@delta> (raw)
In-Reply-To: <patchbomb.1440373750@delta>

# HG changeset patch
# User mischief <mischief@offblast.org>
# Date 1440366687 25200
#      Sun Aug 23 14:51:27 2015 -0700
# Node ID 4d2e0315f59bc5153bd46690b0b43991f24ce121
# Parent  eb135d711d3e30fa57cfa2c87d53a2ac1a1ee34d
tput: use iounit for reads, check sbrk return value

diff -r eb135d711d3e -r 4d2e0315f59b sys/src/cmd/tput.c
--- a/sys/src/cmd/tput.c	Sun Aug 23 14:51:27 2015 -0700
+++ b/sys/src/cmd/tput.c	Sun Aug 23 14:51:27 2015 -0700
@@ -1,10 +1,6 @@
 #include <u.h>
 #include <libc.h>
 
-int dopipe;
-int buflen = 8192;
-uvlong bc, sec;
-
 void
 usage(void)
 {
@@ -16,9 +12,10 @@
 main(int argc, char **argv)
 {
 	double speed;
-	int rc, cpid;
+	int rc, cpid, dopipe, buflen;
+	uvlong bc, sec;
 	char *buf;
-	
+
 	ARGBEGIN {
 	case 'b':
 		buflen = atoi(EARGF(usage()));
@@ -32,10 +29,16 @@
 
 	if(argc != 0)
 		usage();
-	
+
+	buflen = iounit(0);
+	if(buflen <= 0)
+		buflen = IOUNIT;
+
 	bc = 0;
 	sec = 0;
 	buf = sbrk(buflen);
+	if(buf == (void*)-1)
+		sysfatal("out of memory");
 	cpid = rfork(RFPROC | RFMEM);
 	if(cpid == 0) {
 		while(1) {


      parent reply	other threads:[~2015-08-23 23:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-23 23:49 [PATCH 0 of 8] 48k iounit mischief
2015-08-23 23:49 ` [PATCH 1 of 8] devmnt: set MAXRPC to IOHDRSZ+48K mischief
2015-08-23 23:49 ` [PATCH 2 of 8] libc: define default IOUNIT as 48K mischief
2015-08-23 23:49 ` [PATCH 4 of 8] cwfs: use IOUNIT as MAXDAT, fix Msgbuf count overflow when MAXDAT > 2^15-1 mischief
2015-08-23 23:49 ` [PATCH 5 of 8] dossrv: set buffer size to IOUNIT mischief
2015-08-23 23:49 ` [PATCH 6 of 8] mv: use iounit for reads mischief
2015-08-24  0:01   ` [9front] " Iruatã Souza
2015-08-24  0:03     ` Nick Owens
2015-08-23 23:49 ` [PATCH 7 of 8] tee: " mischief
2015-08-23 23:49 ` mischief [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d2e0315f59bc5153bd4.1440373758@delta \
    --to=mischief@offblast.org \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).