Re: [9front] [PATCH] ssh.c algorithm negotiation + ssh-dss key exchange

[Romano <unobe@cpan.org>]

Thanks Cinap!

We discussed a bit on irc, but wanted to thank you again for your feedback.  RFC8709 is now published for ssh-ed25519. My comment was indicating that while 3des-cbc is required, I haven't seen it supported. And I meant to imply chacha20-poly1305 as the stronger algorithm implied by the RFC.


On June 12, 2020 10:58:41 PM UTC, cinap_lenrek@felloff.net wrote:
>no. we'r not going to bring back dsa from the grave.
>
>are you sure rsync.net does not support rsa keys?
>
>they give an example on ther website how to generate a keypair
>using 4096-bit rsa as an example:
>
>https://rsync.net/resources/howto/ssh_keys.html
>
>introducing edwards-curve support should go into libsec,
>and we'd need to add factotum support.
>
>this stuff is fun, but tricky to get right.
>
>we already implemented edwards curves for dp9ik using libmp,
>the reason i havnt added edwards curve support for tls is
>that the intrgration is quite a bit tricky and the standard
>was still in draft at the time.
>
>on the code, it adds quite alot of lines. i hate pointer
>typedefs and i dont like the introduction of global "pub"
>variable. and all these if(strcmp())'s.
>
>also there are some misleading comments:
>
>+	/*
>+	'At some future time, it is expected that another algorithm, one with
>better
>+	strength, will become so prevalent and ubiquitous that the use of
>+	"3des-cbc" will be deprecated by another STANDARDS ACTION.' - RFC4253
>+	No standards action has yet deprecated it, but have not seen it
>supported
>+	by default in any server.
>+	*/
>+	algsp->cipher = "chacha20-poly1305@openssh.com";
>
>what is that supposed to mean? what has 3des todo with
>chacha20-poly1305?
>
>are you trying to indicate that the IETF is going to deprecate it?
>
>--
>cinap