From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
Received: (qmail 20369 invoked from network); 12 Jan 2024 08:08:00 -0000
Received: from 9front.inri.net (168.235.81.73)
  by inbox.vuxu.org with ESMTPUTF8; 12 Jan 2024 08:08:00 -0000
Received: from mail.9lab.org ([168.119.8.41]) by 9front; Fri Jan 12 03:06:24 -0500 2024
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9lab.org; s=20210803;
	t=1705046733;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:  in-reply-to:in-reply-to;
	bh=2TozDL8hXiERacvSq09t3x8uvLCKqGcR2G4CyblADhQ=;
	b=pREkKuIpAoy0bQg4LfCSNGGytc61nz/jh9FzhEqvV6DedSOIFrvR4zuxcDoUPQCxccBV2Y
	ftWW36rRMKdIdL7yJwH7Hasv6Se1zX+klClW0/LzHH3V94hxSrKsiiiUfmDMS27hi9R/t2
	T3Fj9yUuUJMRrR1NBSzWFVNDINFNTs0=
Received: from rob.9lab.home (<unknown> [162.213.162.246])
	by mail.9lab.org (OpenSMTPD) with ESMTPSA id 96865a07 (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO);
	Fri, 12 Jan 2024 09:05:33 +0100 (CET)
Message-ID: <563595A91E31522427D47639E157CA7B@9lab.org>
To: 9front@9front.org
CC: igor@9lab.org
Date: Fri, 12 Jan 2024 09:05:31 +0100
From: igor@9lab.org
In-Reply-To: <2235407F64A748720719B820A36567D0@smtp.pobox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: extension out-scaling YAML over XML wrapper self-signing NoSQL plugin 
Subject: Re: [9front] [PATCH 3/6] nusb/ptp: add mention to nusb man page and fix implementation per spec to start with transaction id 1, not 0.
Reply-To: 9front@9front.org
Precedence: bulk

> So this patch looks good as well?  […]

Thanks!

Just tested it and can now browse iPhone photos on 9front ☺

After applying the fix and plugging in an iPhone, photos are
accessible via '/shr':

  term% ls '/shr/sdU96cb0/Internal Storage/DCIM'
  […]
  '/shr/sdU96cb0/Internal Storage/DCIM/202312__'
  '/shr/sdU96cb0/Internal Storage/DCIM/202401__'

Unless there are any more objections or someone beats me to it I will
merge it this weekend.

Cheers,
Igor

Quoth unobe@cpan.org:
> So this patch looks good as well?  I don't have a commit bit.
> 
> Quoth ori@eigenstate.org:
> > Wait, I retract that.
> > 
> > Quoth Romano <unobe@cpan.org>:
> > > 
> > > Apple iPhones can now be used to transfer images. There is still an issue with the iPhone permission, wherein an actor has to be pretty quick on the trigger to Allow the connection from the iPhone side, but that would require a pause somewhere in the handshake that I did not have time to look into further. This patch at least allows the connection to succeed when permitted.
> > >  	sessionId = getpid();
> > > +	transId   = 0;
> > >  	if(ptprpc(nil, OpenSession, 1, sessionId) < 0)
> > 
> > Setting transid=0 here means that when we
> > enter vptprpc, we do:
> > 
> > 	t = transId++;
> > 	...
> > 	PUT4(rpc.transid, t);
> > 
> > which will put *0* into the transaction ID.
> > Am I missing something here?
> > 
>