Re: [9front] upas/fs plumb modify for self-made flag changes

[ori@eigenstate.org]

> Thanks for your reply and sorry for the noise related to not inlining the patch.
> 
>> This is probably the right thing to do.
> 
> Glad to hear this.
> 
>> Acme Mail both modifies messages and watches for modification
>> notifications. Have you made sure sure that it does the right
>> thing in all cases?
> 
> I have tested it; even with multiple acme Mail instances running at the same time, it did the right thing for all the cases I have tried.
> Having this in my tree for more than a week and using acme Mail as my daily driver I am fairly confident, that this does not introduce any regression.
> 

Sorry for the slow response -- I'm looking again,
and trying to decide if there's a possible bug
here, which existed before your change:

		if(mb->modflags != nil)
			mb->modflags(mb, m, f);
		m->flags = f;
		m->cstate |= Cidxstale;

In imap4modflags, we have:

		imap4cmd(imap, "uid store %lud flags (%s)", (ulong)m->imapuid, buf);
		imap4resp0(imap, mb, m);

imap4resp0 may modfiy the flags to match what's on the
server. I think we want the server to have the final word
after we set the flags, so we want to set them first:

		m->flags = f;
		m->cstate |= Cidxstale;
		m->cstate |= Cmod;
		if(mb->modflags != nil)
			mb->modflags(mb, m, f);

Does this sound right?