From: james palmer <james@biobuf.link>
To: 9front@9front.org
Subject: [9front] Re: [9front] [PATCH] etherbcm: support for newer BCM5717 series cards.
Date: Wed, 22 Feb 2023 19:36:04 +0000 [thread overview]
Message-ID: <5E52249F-37F9-4741-A035-8FE894A0A7BB@biobuf.link> (raw)
In-Reply-To: <3A9DA9FB198F1B1E8FF5C60BD63C5A88@felloff.net>
>phyno() is wrong as it wont set pa to 1 when the switch case doesnt match.
thanks, i will fix that.
>Maybe make the phy address a argument to miir()/miiw()?
i don't know if there is a use for making the phy address an argument, talking to the wrong phy just doesn't work.
maybe it should be stored on the ctlr struct to avoid the function call each time.
next prev parent reply other threads:[~2023-02-22 19:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 18:03 james palmer
2023-02-22 18:54 ` cinap_lenrek
2023-02-22 19:36 ` james palmer [this message]
2023-02-22 21:01 ` james palmer
2023-02-23 0:12 ` cinap_lenrek
2023-02-23 0:08 ` [9front] " cinap_lenrek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5E52249F-37F9-4741-A035-8FE894A0A7BB@biobuf.link \
--to=james@biobuf.link \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).