From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 7219 invoked from network); 22 Feb 2023 19:37:14 -0000 Received: from 9front.inri.net (168.235.81.73) by inbox.vuxu.org with ESMTPUTF8; 22 Feb 2023 19:37:14 -0000 Received: from one.net.tachibana-labs.org ([78.141.198.89]) by 9front; Wed Feb 22 14:36:09 -0500 2023 Received: from [127.0.0.1] (cpc99362-croy26-2-0-cust24.19-2.cable.virginm.net [80.195.49.25]) by one.net.tachibana-labs.org (OpenSMTPD) with ESMTPSA id da329362 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <9front@9front.org>; Wed, 22 Feb 2023 19:36:04 +0000 (UTC) Date: Wed, 22 Feb 2023 19:36:04 +0000 From: james palmer To: 9front@9front.org User-Agent: K-9 Mail for Android In-Reply-To: <3A9DA9FB198F1B1E8FF5C60BD63C5A88@felloff.net> References: <3A9DA9FB198F1B1E8FF5C60BD63C5A88@felloff.net> Message-ID: <5E52249F-37F9-4741-A035-8FE894A0A7BB@biobuf.link> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: content-addressed distributed GPU rails database Subject: [9front] =?US-ASCII?Q?Re=3A_=5B9front=5D_=5BPATCH=5D_etherbcm=3A_supp?= =?US-ASCII?Q?ort_for_newer_BCM5717_series_cards=2E?= Reply-To: 9front@9front.org Precedence: bulk >phyno() is wrong as it wont set pa to 1 when the switch case doesnt match= =2E thanks, i will fix that=2E >Maybe make the phy address a argument to miir()/miiw()? i don't know if there is a use for making the phy address an argument, tal= king to the wrong phy just doesn't work=2E maybe it should be stored on the ctlr struct to avoid the function call ea= ch time=2E