From: BurnZeZ@feline.systems
To: 9front@9front.org
Subject: rc-httpd bug
Date: Mon, 9 Feb 2015 03:15:27 -0500 [thread overview]
Message-ID: <5ac577fe5abc816f182b1d32da8334d2@utsuho.znet> (raw)
lachs0r pointed out a bug involving the request handling.
When someone makes a request, rc-httpd does not limit the size of the request.
It loops getting lines until the request is complete, or rc runs out of memory.
fn getline{ read | sed 's/'^$"cr^'$//g' }
done=false
while(~ $"done false){
line=`{getline}
if(~ $#line 0)
done=true
reqlines=$"reqlines$"line'
'
The preceding excerpts should make the problem apparent.
See /rc/bin/rc-httpd/rc-httpd:/^done/
Another thing of note is that read(1) as used here will read until newline
with no regard for how much data is read.
RFC2616 section 10.4.14 speaks of a response, 413 Request Entity Too Large
> The server is refusing to process a request because the request
> entity is larger than the server is willing or able to process. The
> server MAY close the connection to prevent the client from continuing
> the request.
>
> If the condition is temporary, the server SHOULD include a Retry-
> After header field to indicate that it is temporary and after what
> time the client MAY try again.
This definition leaves it up to the server to decide how much crap it tolerates.
From a quick glance at a few http server implementations, I see limits varying from 1-48 KB.
I'm not familiar enough with http to know how to impose such a limitation without
breaking things.
next reply other threads:[~2015-02-09 8:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 8:15 BurnZeZ [this message]
2015-02-09 14:55 ` [9front] " Kurt H Maier
2015-02-10 13:35 ` BurnZeZ
2015-02-10 15:19 ` Kurt H Maier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ac577fe5abc816f182b1d32da8334d2@utsuho.znet \
--to=burnzez@feline.systems \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).