From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.0 required=5.0 tests=T_SCC_BODY_TEXT_LINE
	autolearn=ham autolearn_force=no version=3.4.4
Received: (qmail 27416 invoked from network); 18 Aug 2022 02:24:58 -0000
Received: from 9front.inri.net (168.235.81.73)
  by inbox.vuxu.org with ESMTPUTF8; 18 Aug 2022 02:24:58 -0000
Received: from mimir.eigenstate.org ([206.124.132.107]) by 9front; Wed Aug 17 22:23:20 -0400 2022
Received: from abbatoir.myfiosgateway.com (pool-74-108-56-137.nycmny.fios.verizon.net [74.108.56.137])
	by mimir.eigenstate.org (OpenSMTPD) with ESMTPSA id 63e2b79c (TLSv1.2:ECDHE-RSA-AES256-SHA:256:NO)
	for <9front@9front.org>;
	Wed, 17 Aug 2022 19:23:10 -0700 (PDT)
Message-ID: <614F45799921E978382B1562E32B1F75@eigenstate.org>
To: 9front@9front.org
Date: Wed, 17 Aug 2022 22:23:08 -0400
From: ori@eigenstate.org
In-Reply-To: <7DE45F6F2F4B23487CB9F730D2DC5921@wopr.sciops.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: managed API just-in-time interface 
Subject: Re: [9front] fix race condition on writes to #v/vgactl
Reply-To: 9front@9front.org
Precedence: bulk

Quoth qwx@sciops.net:
> 
> You're absolutely right.  Here's another attempt; the code is a mess,
> but I'm not up for refactoring it all right now.
> 
> What do you think?
> 

looks ok to me.

Though, I wonder if we can just simplify by taking the lock on
entry, and release it on return; I don't think that any of
these operations happen often, so we don't need to be fine
grained.