[9front] deleting ape/diff?

[9front] deleting ape/diff?

[ori]

now that diff(1) supports unified diff,
merge3 exists and can do 3-way merge,
and git is a trivial commit away from
switching to the native merge3 code,
is there any reason to keep around
ape/diff?

If not, I'd like to nuke it; it's big,
hairy, unmaintained, and crashy.

% git/diff /sys/src/ape/cmd/diff | wc -l
  24034

Re: [9front] deleting ape/diff?

[Lucas Francesco]

I see no reason to keep it, even as an ape defender, so long as it
works in ape/psh  :P

Nice job, ori!

On Mon, 29 Jul 2024 at 22:02, <ori@eigenstate.org> wrote:
>
> now that diff(1) supports unified diff,
> merge3 exists and can do 3-way merge,
> and git is a trivial commit away from
> switching to the native merge3 code,
> is there any reason to keep around
> ape/diff?
>
> If not, I'd like to nuke it; it's big,
> hairy, unmaintained, and crashy.
>
> % git/diff /sys/src/ape/cmd/diff | wc -l
>   24034
>

Re: [9front] deleting ape/diff?

[sirjofri]

30.07.2024 03:57:56 Lucas Francesco <lucas.francesco93@gmail.com>:
> I see no reason to keep it, even as an ape defender, so long as it
> works in ape/psh  :P
>
> Nice job, ori!
>
> On Mon, 29 Jul 2024 at 22:02, <ori@eigenstate.org> wrote:
>>
>> now that diff(1) supports unified diff,
>> merge3 exists and can do 3-way merge,
>> and git is a trivial commit away from
>> switching to the native merge3 code,
>> is there any reason to keep around
>> ape/diff?
>>
>> If not, I'd like to nuke it; it's big,
>> hairy, unmaintained, and crashy.

I personally don't use it, but some other people might. Does it make sense to replace it with some shell script that just calls merge3 and diff?

sirjofri

Re: [9front] deleting ape/diff?

[Jacob Moody]

On 7/30/24 00:04, sirjofri wrote:
> 30.07.2024 03:57:56 Lucas Francesco <lucas.francesco93@gmail.com>:
>> I see no reason to keep it, even as an ape defender, so long as it
>> works in ape/psh  :P
>>
>> Nice job, ori!
>>
>> On Mon, 29 Jul 2024 at 22:02, <ori@eigenstate.org> wrote:
>>>
>>> now that diff(1) supports unified diff,
>>> merge3 exists and can do 3-way merge,
>>> and git is a trivial commit away from
>>> switching to the native merge3 code,
>>> is there any reason to keep around
>>> ape/diff?
>>>
>>> If not, I'd like to nuke it; it's big,
>>> hairy, unmaintained, and crashy.
> 
> I personally don't use it, but some other people might. Does it make sense to replace it with some shell script that just calls merge3 and diff?
> 
> sirjofri

The interface is different enough (for flags and the like), that without some effort to mimicing the interface scripts are likely to fail regardless.
I'd say just remove it, let people know and let it break loudly.


Thanks,
moody

Re: [9front] deleting ape/diff?

[ori]

Quoth ori@eigenstate.org:
> now that diff(1) supports unified diff,
> merge3 exists and can do 3-way merge,
> and git is a trivial commit away from
> switching to the native merge3 code,
> is there any reason to keep around
> ape/diff?
> 
> If not, I'd like to nuke it; it's big,
> hairy, unmaintained, and crashy.
> 
> % git/diff /sys/src/ape/cmd/diff | wc -l
>   24034
> 

nuked it.