9front - general discussion about 9front
 help / color / mirror / Atom feed
From: ori@eigenstate.org
To: 9front@9front.org
Subject: Re: [9front] [patch] cdfs handle block sizes correctly
Date: Sat, 01 Oct 2022 17:20:14 -0400	[thread overview]
Message-ID: <63930A6D48F026FB3A6DAA769914CA81@eigenstate.org> (raw)
In-Reply-To: <827131327.3389568.1664620465910@comcenter.netcologne.de>

Quoth Arne Meyer <meyer.arne83@netcologne.de>:
> The Readblock enum does not work when you try to read audio cds.  4
> cdda blocks are lager than 8192 and the command fails (at least when
> using an usb cd drive).  This sets the block count according to the
> track block size.  With this and the fix for libdisk I can rip audio
> cds on my el cheapo usb dvd drive.  Tested with "Midnight Oil - Blue
> Sky Mining"
> Greetings,
> Arne

>  typedef struct Buf Buf;
> --- a/sys/src/cmd/cdfs/mmc.c
> +++ b/sys/src/cmd/cdfs/mmc.c
> @@ -1171,7 +1171,7 @@
>         o->track = &drive->track[trackno];
>         o->nchange = drive->nchange;
>         o->omode = OREAD;
> -       o->buf = bopen(mmcread, OREAD, o->track->bs, Readblock);
> +       o->buf = bopen(mmcread, OREAD, o->track->bs, Maxrpc/o->track->bs);

these changes smell funny to me; if the block size is larger than Maxrpc, we
set nblock to 0. Looking at bread in buf.c, it seems like we'd simplly end up
trying to read 0 bytes out of these large buffers.

  reply	other threads:[~2022-10-01 21:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-01 10:34 Arne Meyer
2022-10-01 21:20 ` ori [this message]
2022-10-02 18:56   ` Arne Meyer
2022-10-02 20:04     ` ori
2022-10-22 16:20       ` Arne Meyer
2022-10-22 18:43         ` ori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63930A6D48F026FB3A6DAA769914CA81@eigenstate.org \
    --to=ori@eigenstate.org \
    --cc=9front@9front.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).