From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <9front-bounces@9front.inri.net>
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI autolearn=ham
	autolearn_force=no version=3.4.4
Received: from 9front.inri.net (9front.inri.net [168.235.81.73])
	by inbox.vuxu.org (Postfix) with ESMTP id 574BC29921
	for <ml@inbox.vuxu.org>; Thu, 30 May 2024 22:46:24 +0200 (CEST)
Received: from wopr.sciops.net ([216.126.196.60]) by 9front; Thu May 30 16:43:06 -0400 2024
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sciops.net; s=20210706;
	t=1717101733;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:  in-reply-to:in-reply-to;
	bh=quZQj7x+7o6myxWVN5wM2F/QADTAcvV8GXmaaK4tyCw=;
	b=jT/KRTUPG/1R4IvGcS5SiH/TnA2mkktGM2tvaYFhFkeOI442rSYE3fjMfGPSwA8QXEHu/5
	j9pPw3HHj/v7iGXFYMOje8BFxSTpaywEtTNdSp4Bz2BV5CpWrumVDSguCgBtWPHdYbgThs
	aH0OJ+3WALdJGFuGu5K2uyFu4z9d0i4=
Received: 
	by wopr.sciops.net (OpenSMTPD) with ESMTPSA id 0dfd970d (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO)
	for <9front@9front.org>;
	Thu, 30 May 2024 13:42:13 -0700 (PDT)
Message-ID: <6B2FF0B569E4CA873C1A920E87C0138A@wopr.sciops.net>
Date: Thu, 30 May 2024 22:42:57 +0200
From: qwx@sciops.net
To: 9front@9front.org
In-Reply-To: <theynkqod2ggcrvgmtskynv2uuapziku5i5fnwvsjbbtmq3kqt@u4ul6ekucn3g>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: abstract managed DOM-oriented module property method-oriented manager 
Subject: Re: [9front] sys/src/cmd/gs/spim.h should not be checked in?
Reply-To: 9front@9front.org
Precedence: bulk

On Thu May 30 00:22:22 +0200 2024, falsifian@falsifian.org wrote:
> Hi,
> 
> On a fresh install from a recent nightly*, git/diff (after 
> cd /; bind -ac /dist/plan9front /; git/fs) includes this hunk:
> 
> 	--- a/sys/src/cmd/gs/spim.h
> 	+++ b/sys/src/cmd/gs/spim.h
> 	@@ -1,3 +1,3 @@
> 	-#include "mips.h"
> 	+#include "default.mips.h"
> 	 #undef ARCH_IS_BIG_ENDIAN
> 	 #define ARCH_IS_BIG_ENDIAN 0
> 
> It looks like the mkfile generates spim.h by copying default.spim.h 
> and so unless I'm missing something spim.h should just not be checked 
> in.
> 
> (The only other hunk in git/diff output is is adding bootflile= to 
> /sys/lib/dist/cfg/plan9.ini which makes sense.)
> 
> -- 
> James

I think you're correct.  If no one objects, we should git/rm it.

Thanks,
qwx