Re: [9front] [PATCH] Update hpost to use -r header like hget

[estevan.cps@gmail.com]

Hello,

> I had issues with just expanding the headers using -r^headers. It 
> generates an hget command like (just an echo before line 98):
> 
> hget -rX-Foo: Lol -rAuthorization: Bearer Token -r Content-Type: 
> multipart/form-data; boundary=HJBOUNDARY -b https://httpbin.org -P /post

The output from that echo is likely misleading, "-rX-Foo: Lol", for example, has a space in it but is passed as a single argument to the program; you'd probably be better off testing that sort of stuff with something that shows arguments separately (unless you're aware of the implications of echoing it and don't care); the following could be helpful:

#!/bin/rc

for(i in `{seq 0 $#*})
	echo $i: $*($i)

> where a valid hget command would be:
> hget -r 'X-Foo: Lol' -r 'Authorization: Bearer Token' -r 'Content-Type: 
> multipart/form-data; boundary=HJBOUNDARY' -b https://httpbin.org -P /post

That's rather inconsistent with, i.e. how arg(2) would parse flags though; (unless I'm overlooking something probably really simple) it probably should handle the argument to the flag whether it is in the same "argv-argument" or not. That can probably be achieved by rewriting hget (and hpost, for that matter) to use something like getflags(8), but that would probably require a patch to getflags to handle "variadic flag arguments" (so multiple -r flags would add the contents to a list instead of overwriting them in turn like it would do now). Could probably sketch something a little bit later (maybe someone has something to add as well?).

Hope that's helpful,

--
Tevo