From: qwx@sciops.net
To: 9front@9front.org
Subject: Re: [9front] displayport thinkpad x230 external monitor black screen
Date: Sun, 30 Apr 2023 05:12:34 +0200 [thread overview]
Message-ID: <6CD9EC4EFCD1E88C168FDDC61F0D2C60@wopr.sciops.net> (raw)
In-Reply-To: <1E91A12F12C601E2DE1A3099207ADE0C@smtp.pobox.com>
On Wed Apr 26 05:39:14 +0200 2023, unobe@cpan.org wrote:
> Of the issues you brought up, I was certain about how to fix the 'i =
> 1;' -> 'break;', but less certain of how to match the surrounding code
> in all cases. The for loops spacing was easy enough, and the added
> space at the end of a for loop that was unneeded (i.e., hunk @@
> -2319,7, +2363,7 @@).
>
> However, the shift operators I saw have both styles even within the
> same block. In some cases there were surrounding spaces, and in
> others there weren't (e.g., hunk @@-2219,46 +2300,37 @@). I don't
> want to delay the push of the patch needlessly, but also don't want to
> create disturbances in the Force by not catching the ones you noticed.
> So I'd prefer you to fixup as you see fit.
>
> Sincerely,
> Romano
I did a bunch of bikeshedding, more than enough, and just commited
this. It wouldn't have been terrible to push it as it was when you
sent it originally, like I said I only had minor comments on style --
so, bikeshedding. You'll find plenty of examples of differences in
style in the tree, the point is to just not help form any mutinies of
deviated preverts who use a significantly different style clashing
with everything else (but not even the case here).
Anyway, thanks again for your work!
Cheers,
qwx
next prev parent reply other threads:[~2023-04-30 3:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-09 21:26 qwx
2023-04-09 22:42 ` sirjofri
2023-04-11 21:33 ` Steve Simon
2023-04-12 22:13 ` unobe
2023-04-11 21:32 ` Roberto E. Vargas Caballero
2023-04-17 7:53 ` qwx
2023-04-19 20:50 ` unobe
2023-04-20 23:40 ` qwx
2023-04-24 18:52 ` qwx
2023-04-26 3:32 ` unobe
2023-04-30 3:12 ` qwx [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-30 17:37 Romano
2023-03-30 17:47 ` Stanley Lieber
2023-04-03 22:27 ` qwx
2023-04-04 22:39 ` igor
2023-04-04 22:43 ` sl
2023-04-05 7:01 ` qwx
2023-04-09 6:59 ` unobe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6CD9EC4EFCD1E88C168FDDC61F0D2C60@wopr.sciops.net \
--to=qwx@sciops.net \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).