From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from outgoing.selfhost.de ([82.98.82.6]) by ewsd; Tue Feb 13 05:04:25 EST 2018 Received: (qmail 19760 invoked from network); 13 Feb 2018 10:04:23 -0000 Received: from unknown (HELO mx02.bss-wf.de) (postmaster@emdtgvmf.mail.selfhost.de@84.190.153.67) by mailout.selfhost.de with ESMTPA; 13 Feb 2018 10:04:23 -0000 Received: from [10.0.27.175] (port-13323.pppoe.wtnet.de [84.46.52.63]) by mx02.bss-wf.de (Postfix) with ESMTPSA id 98BC92173C for <9front@9front.org>; Tue, 13 Feb 2018 11:04:22 +0100 (CET) To: 9front@9front.org From: Tobias Heinicke Subject: movetodel function in acme not called Message-ID: <70d58181-fb8e-adf4-f7c8-3e1b63f6e970@bss-wf.de> Date: Tue, 13 Feb 2018 11:02:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Icedove/52.6.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4GGAE4yLXcASozolqLyYnSQBjExlbGKbP" List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: open-source service-scale map/reduce manager This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4GGAE4yLXcASozolqLyYnSQBjExlbGKbP Content-Type: multipart/mixed; boundary="GZNphJA1kgiYca2sSqeuTtsRRYSSdmJKL"; protected-headers="v1" From: Tobias Heinicke To: 9front@9front.org Message-ID: <70d58181-fb8e-adf4-f7c8-3e1b63f6e970@bss-wf.de> Subject: movetodel function in acme not called --GZNphJA1kgiYca2sSqeuTtsRRYSSdmJKL Content-Type: multipart/mixed; boundary="------------D21B9F0654ACAFDA0D06E33C" Content-Language: en-US This is a multi-part message in MIME format. --------------D21B9F0654ACAFDA0D06E33C Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, first of all I would like to thank you for developing 9front and thus keeping plan9 alive and kicking. I was just wondering whether there is a reason for movetodel() being committed, without being ever used. The function was added in p9p as part of rsc's effort to allow deleting several acme windows in a column without having to move the mouse pointer (committed on 2012-09-23 - 37f8ed2410ad5cbd46eda00a77f8bf4950bcf544). In 9front the function definition was added on 2013-08-29 (Node ID: 3af7b07be732a15a30e323134f8056986ca4e0ed), but the code to call it is missing (and thus deleting a sequence of windows in 9front's acme still requires moving the mouse a lot). So far I have recursively grep'd the mail archives for 'movetodel', but have not found anything. If the behaviour implemented by rsc is desirable I suggest adding it. Attached is a diff of the code that is missing for rsc's feature to be available in 9front's acme (created using hg diff, if you would rather like to see a patch (e.g. committing the changes and hg export or sth.?), feel free to tell me). Sorry for probably not complying to any rules, as I am fairly new to using 9front (and been lurking this mailing list even less [- subscribed with a different address]). Best regards, Tobias Heinicke P.S.: Sorry for my English, I am not a native speaker. --------------D21B9F0654ACAFDA0D06E33C Content-Type: text/plain; charset=UTF-8; name="utilizeMovetodelDiff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="utilizeMovetodelDiff" ZGlmZiAtciAwYjk3NTM2ZTJiY2Qgc3lzL3NyYy9jbWQvYWNtZS9jb2xzLmMKLS0tIGEvc3lz L3NyYy9jbWQvYWNtZS9jb2xzLmMJTW9uIEZlYiAwNSAxOToxNjoyOSAyMDE4ICswMTAwCisr KyBiL3N5cy9zcmMvY21kL2FjbWUvY29scy5jCVR1ZSBGZWIgMTMgMDg6NDU6NTEgMjAxOCAr MDEwMApAQCAtMTExLDcgKzExMSw3IEBACiBjb2xjbG9zZShDb2x1bW4gKmMsIFdpbmRvdyAq dywgaW50IGRvZnJlZSkKIHsKIAlSZWN0YW5nbGUgcjsKLQlpbnQgaTsKKwlpbnQgaSwgZGlk bW91c2UsIHVwOwogCiAJLyogdyBpcyBsb2NrZWQgKi8KIAlpZighYy0+c2FmZSkKQEAgLTEy NSw3ICsxMjUsNyBAQAogCXctPnRhZy5jb2wgPSBuaWw7CiAJdy0+Ym9keS5jb2wgPSBuaWw7 CiAJdy0+Y29sID0gbmlsOwotCXJlc3RvcmVtb3VzZSh3KTsKKwlkaWRtb3VzZSA9IHJlc3Rv cmVtb3VzZSh3KTsKIAlpZihkb2ZyZWUpewogCQl3aW5kZWxldGUodyk7CiAJCXdpbmNsb3Nl KHcpOwpAQCAtMTM3LDE3ICsxMzcsMjQgQEAKIAkJZHJhdyhzY3JlZW4sIHIsIGRpc3BsYXkt PndoaXRlLCBuaWwsIFpQKTsKIAkJcmV0dXJuOwogCX0KKwl1cCA9IDA7CiAJaWYoaSA9PSBj LT5udyl7CQkvKiBleHRlbmQgbGFzdCB3aW5kb3cgZG93biAqLwogCQl3ID0gYy0+d1tpLTFd OwogCQlyLm1pbi55ID0gdy0+ci5taW4ueTsKIAkJci5tYXgueSA9IGMtPnIubWF4Lnk7CiAJ fWVsc2V7CQkJLyogZXh0ZW5kIG5leHQgd2luZG93IHVwICovCisJCXVwID0gMTsKIAkJdyA9 IGMtPndbaV07CiAJCXIubWF4LnkgPSB3LT5yLm1heC55OwogCX0KIAlkcmF3KHNjcmVlbiwg ciwgdGV4dGNvbHNbQkFDS10sIG5pbCwgWlApOwotCWlmKGMtPnNhZmUpCisJaWYoYy0+c2Fm ZSkgeworCQlpZighZGlkbW91c2UgJiYgdXApCisJCQl3LT5zaG93ZGVsID0gVFJVRTsKIAkJ d2lucmVzaXplKHcsIHIsIEZBTFNFKTsKKwkJaWYoIWRpZG1vdXNlICYmIHVwKQorCQkJbW92 ZXRvZGVsKHcpOworCX0KIH0KIAogdm9pZApkaWZmIC1yIDBiOTc1MzZlMmJjZCBzeXMvc3Jj L2NtZC9hY21lL2Zucy5oCi0tLSBhL3N5cy9zcmMvY21kL2FjbWUvZm5zLmgJTW9uIEZlYiAw NSAxOToxNjoyOSAyMDE4ICswMTAwCisrKyBiL3N5cy9zcmMvY21kL2FjbWUvZm5zLmgJVHVl IEZlYiAxMyAwODo0NTo1MSAyMDE4ICswMTAwCkBAIC0xOSwxMCArMTksMTEgQEAKIGNoYXIq CWdldG5hbWUoVGV4dCosIFRleHQqLCBSdW5lKiwgaW50LCBpbnQpOwogdm9pZAlzY3JzbGVl cCh1aW50KTsKIHZvaWQJc2F2ZW1vdXNlKFdpbmRvdyopOwotdm9pZAlyZXN0b3JlbW91c2Uo V2luZG93Kik7CitpbnQJCXJlc3RvcmVtb3VzZShXaW5kb3cqKTsKIHZvaWQJY2xlYXJtb3Vz ZSh2b2lkKTsKIHZvaWQJYWxsd2luZG93cyh2b2lkKCopKFdpbmRvdyosIHZvaWQqKSwgdm9p ZCopOwogdWludCBsb2FkZmlsZShpbnQsIHVpbnQsIGludCosIGludCgqKSh2b2lkKiwgdWlu dCwgUnVuZSosIGludCksIHZvaWQqKTsKK3ZvaWQJbW92ZXRvZGVsKFdpbmRvdyopOwogCiBX aW5kb3cqCWVycm9yd2luKE1udGRpciosIGludCk7CiBXaW5kb3cqCWVycm9yd2luZm9yd2lu KFdpbmRvdyopOwpkaWZmIC1yIDBiOTc1MzZlMmJjZCBzeXMvc3JjL2NtZC9hY21lL3V0aWwu YwotLS0gYS9zeXMvc3JjL2NtZC9hY21lL3V0aWwuYwlNb24gRmViIDA1IDE5OjE2OjI5IDIw MTggKzAxMDAKKysrIGIvc3lzL3NyYy9jbWQvYWNtZS91dGlsLmMJVHVlIEZlYiAxMyAwODo0 NTo1MSAyMDE4ICswMTAwCkBAIC0zNjYsMTIgKzM2NiwxOCBAQAogCW1vdXNldyA9IHc7CiB9 CiAKLXZvaWQKK2ludAogcmVzdG9yZW1vdXNlKFdpbmRvdyAqdykKIHsKLQlpZihtb3VzZXch PW5pbCAmJiBtb3VzZXc9PXcpCisJaW50IGRpZDsKKworCWRpZCA9IDA7CisJaWYobW91c2V3 IT1uaWwgJiYgbW91c2V3PT13KSB7CiAJCW1vdmV0byhtb3VzZWN0bCwgcHJldm1vdXNlKTsK KwkJZGlkID0gMTsKKwl9CiAJbW91c2V3ID0gbmlsOworCXJldHVybiBkaWQ7CiB9CiAKIHZv aWQK --------------D21B9F0654ACAFDA0D06E33C-- --GZNphJA1kgiYca2sSqeuTtsRRYSSdmJKL-- --4GGAE4yLXcASozolqLyYnSQBjExlbGKbP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFIBAEBCgAyFiEE79xIM7IZMyMohXYreKcIhFhwNK8FAlqCt9AUHHRoZWluaWNr ZUBic3Mtd2YuZGUACgkQeKcIhFhwNK/oKgf/RnhYgCaZfUmYbUpCfKTbpsHdoD/z 3GGgJSE8J+hVrAgXzL0bW9U8W4pFaW3EYj7Yo+MjGe/Sa4i4BwEZm74+ywxUThHN wIbFCNDaJfbdNotaE1GlvipdVyPQ6VPrK8Zyxaj4ybbSXZVTvTICBhqme+LRiV+a oGf2UIi5EpTL8y0KyYzT38I1clGo2mHmqtr6FQglus/d3DhbiKFXzAggTDW8areA H1755BaL38OURlB+FckDuMnu3SoWsPM8AQQV+zA855z97ITlTDoP4ioN4xJdgl/M JcYicINOn034L/fRWATePNvBZnxwpahL+89pt6eXaBAj2ouuwHvCLsTcCA== =QbTr -----END PGP SIGNATURE----- --4GGAE4yLXcASozolqLyYnSQBjExlbGKbP--