From: ori@eigenstate.org
To: 9front@9front.org
Subject: Re: [9front] deleting ape/diff3, ape/diff, and ape/patch?
Date: Mon, 22 Jan 2024 07:00:50 -0500 [thread overview]
Message-ID: <752FCD171F7EDD5936E90B789923F269@eigenstate.org> (raw)
In-Reply-To: <83D5720B7674D9BDA3CFE64D9CB77A88@eigenstate.org>
Also, for people doing a lot of diffing and merging, if
you could test out the following diff and report back
on any issues, I would appreciate that:
diff 26c21f9b5d06296d13f40b53de14e22007e189c2 uncommitted
--- a/sys/lib/git/common.rc
+++ b/sys/lib/git/common.rc
@@ -87,7 +87,7 @@
if(mergeperm $ours $base $theirs){
mkdir -p `{basename -d $tmp}
- if(! ape/diff3 -3 -m $ours $base $theirs > $tmp)
+ if(! merge3 $ours $base $theirs > $tmp)
echo merge needed: $out >[1=2]
mv $tmp $out
git/add $out
Quoth ori@eigenstate.org:
> As of the last commit to cmd/diff/merge3, we should have
> a usable native 3-way merge in tree. Barring bugs, it
> should be able to do all that our in-tree scripts need.
>
> As a result, I'd like to remove the buggy, crashy, and
> obsolte ape/patch, ape/diff, and ape/diff3 utilities
> from our tree by default, and move it into an extrenal
> repository, where it will be just as well maintaned as
> it was in-tree.
>
> Are there any people currently using them in scripts?
> Are there any missing features that would prevent a
> transition of them to the native tools?
>
> We will be losing the ability to apply non-unified
> patches.
>
> Are there any other objections?
>
next prev parent reply other threads:[~2024-01-22 12:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-21 3:16 ori
2024-01-22 12:00 ` ori [this message]
2024-01-22 15:02 ` Jacob Moody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=752FCD171F7EDD5936E90B789923F269@eigenstate.org \
--to=ori@eigenstate.org \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).