From: ori@eigenstate.org
To: 9front@9front.org
Subject: Re: [9front] [patch] fix nusb/disk with libdisk
Date: Sat, 01 Oct 2022 17:10:32 -0400 [thread overview]
Message-ID: <7560A06E80A4299AD21CCA9EDB299AC7@eigenstate.org> (raw)
In-Reply-To: <1762238476.3388935.1664619322029@comcenter.netcologne.de>
Quoth Arne Meyer <meyer.arne83@netcologne.de>:
> libdisk openscsi expects that when reading the ctl file, it starts with "inquiry". All other sd drivers do this, so nusb/disk should too.
patch looks good, but doesn't apply; your mail client appears to have replaced
tabs with spaces.
I'll do the surgery this time.
>
> Greetings,
> Arne
>
> diff e938acc8ff64a3cbbd6ef7ba88f83e3f03ede681 uncommitted
> --- a/sys/src/cmd/nusb/disk/disk.c
> +++ b/sys/src/cmd/nusb/disk/disk.c
> @@ -155,10 +155,10 @@
> part = &lun->part[0];
>
> fmtstrinit(&fmt);
> - fmtprint(&fmt, "dev %s\n", dev->dir);
> - fmtprint(&fmt, "lun %zd\n", lun - &ums->lun[0]);
> if(lun->flags & Finqok)
> fmtprint(&fmt, "inquiry %s\n", lun->inq);
> + fmtprint(&fmt, "dev %s\n", dev->dir);
> + fmtprint(&fmt, "lun %zd\n", lun - &ums->lun[0]);
> if(lun->blocks > 0)
> fmtprint(&fmt, "geometry %llud %ld\n", lun->blocks, lun->lbsize);
> for (p = &part[Qdata+1]; p < &part[Qmax]; p++)
prev parent reply other threads:[~2022-10-01 21:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 10:15 Arne Meyer
2022-10-01 21:10 ` ori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7560A06E80A4299AD21CCA9EDB299AC7@eigenstate.org \
--to=ori@eigenstate.org \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).