From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 2749 invoked from network); 1 Oct 2022 21:13:13 -0000
Received: from 9front.inri.net (168.235.81.73)
  by inbox.vuxu.org with ESMTPUTF8; 1 Oct 2022 21:13:13 -0000
Received: from mimir.eigenstate.org ([206.124.132.107]) by 9front; Sat Oct  1 17:10:37 -0400 2022
Received: from stockyard.localdomain (cpe-68-174-86-38.nyc.res.rr.com [68.174.86.38])
	by mimir.eigenstate.org (OpenSMTPD) with ESMTPSA id 9baa240f (TLSv1.2:ECDHE-RSA-AES256-SHA:256:NO)
	for <9front@9front.org>;
	Sat, 1 Oct 2022 14:10:35 -0700 (PDT)
Message-ID: <7560A06E80A4299AD21CCA9EDB299AC7@eigenstate.org>
To: 9front@9front.org
Date: Sat, 01 Oct 2022 17:10:32 -0400
From: ori@eigenstate.org
In-Reply-To: <1762238476.3388935.1664619322029@comcenter.netcologne.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: abstract lossless storage general-purpose extension 
Subject: Re: [9front] [patch] fix nusb/disk with libdisk
Reply-To: 9front@9front.org
Precedence: bulk

Quoth Arne Meyer <meyer.arne83@netcologne.de>:
> libdisk openscsi expects that when reading the ctl file, it starts with "inquiry". All other sd drivers do this, so nusb/disk should too.

patch looks good, but doesn't apply; your mail client appears to have replaced
tabs with spaces.

I'll do the surgery this time.

> 
> Greetings,
> Arne
> 
> diff e938acc8ff64a3cbbd6ef7ba88f83e3f03ede681 uncommitted
> --- a/sys/src/cmd/nusb/disk/disk.c
> +++ b/sys/src/cmd/nusb/disk/disk.c
> @@ -155,10 +155,10 @@
>         part = &lun->part[0];
> 
>         fmtstrinit(&fmt);
> -       fmtprint(&fmt, "dev %s\n", dev->dir);
> -       fmtprint(&fmt, "lun %zd\n", lun - &ums->lun[0]);
>         if(lun->flags & Finqok)
>                 fmtprint(&fmt, "inquiry %s\n", lun->inq);
> +       fmtprint(&fmt, "dev %s\n", dev->dir);
> +       fmtprint(&fmt, "lun %zd\n", lun - &ums->lun[0]);
>         if(lun->blocks > 0)
>                 fmtprint(&fmt, "geometry %llud %ld\n", lun->blocks, lun->lbsize);
>         for (p = &part[Qdata+1]; p < &part[Qmax]; p++)