From: ori@eigenstate.org
To: 9front@9front.org
Subject: Re: [9front] [PATCH] troff: we are not htmlroff
Date: Sat, 04 Dec 2021 19:00:03 -0500 [thread overview]
Message-ID: <79A0159AB3C06473EA8CE47C04ABCB86@eigenstate.org> (raw)
In-Reply-To: <YaKKfQJND/v4LIeE@beryllium.local>
Quoth Humm <hummsmith42@gmail.com>:
>
> If we don’t explicitly check for ‘h’ in troff, we can’t reliably check
> for non-htmlroff well.
>
> Consider the following:
>
> .if h \{\
> . de M
> . tm m
> ..\}
>
> Without this change, this will print m and not define macro M.
> ---
> diff 24b9a78ceb63234ef0b0e7d1da0d46119b7a297d c2f89dc6c142284fc3b4c38a4e9fbf5c0c5b2a1d
> --- a/sys/src/cmd/troff/n5.c Wed Nov 24 15:41:36 2021
> +++ b/sys/src/cmd/troff/n5.c Wed Nov 24 20:56:44 2021
> @@ -683,6 +683,7 @@
> if (TROFF)
> true++;
> break;
> + case 'h':
> case ' ':
> break;
> default:
>
Generally looks ok to me, but I'm not a troff expert.
Was hoping someone a bit more knowlegable would look,
but I'm willing to commit if nobody else pipes up.
thanks for pinging.
prev parent reply other threads:[~2021-12-05 1:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-27 19:43 Humm
2021-12-04 23:23 ` Humm
2021-12-04 23:46 ` Sigrid Solveig Haflínudóttir
2021-12-05 1:24 ` Humm
2021-12-05 1:48 ` Sigrid Solveig Haflínudóttir
2021-12-05 0:46 ` Noam Preil
2021-12-05 1:19 ` Noam Preil
2021-12-05 2:36 ` Humm
2021-12-05 13:22 ` Noam Preil
2021-12-05 1:19 ` Humm
2021-12-05 0:00 ` ori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79A0159AB3C06473EA8CE47C04ABCB86@eigenstate.org \
--to=ori@eigenstate.org \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).