From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 27377 invoked from network); 5 Dec 2021 01:00:20 -0000
Received: from 4ess.inri.net (216.126.196.42)
  by inbox.vuxu.org with ESMTPUTF8; 5 Dec 2021 01:00:20 -0000
Received: from mimir.eigenstate.org ([206.124.132.107]) by 4ess; Sat Dec  4 19:08:43 -0500 2021
Received: from abbatoir.myfiosgateway.com (pool-74-108-56-225.nycmny.fios.verizon.net [74.108.56.225])
	by mimir.eigenstate.org (OpenSMTPD) with ESMTPSA id 01b8bd1a (TLSv1.2:ECDHE-RSA-AES256-SHA:256:NO)
	for <9front@9front.org>;
	Sat, 4 Dec 2021 16:00:04 -0800 (PST)
Message-ID: <79A0159AB3C06473EA8CE47C04ABCB86@eigenstate.org>
To: 9front@9front.org
Date: Sat, 04 Dec 2021 19:00:03 -0500
From: ori@eigenstate.org
In-Reply-To: <YaKKfQJND/v4LIeE@beryllium.local>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: converged grid content-driven engine-aware controller 
Subject: Re: [9front] [PATCH] troff: we are not htmlroff
Reply-To: 9front@9front.org
Precedence: bulk

Quoth Humm <hummsmith42@gmail.com>:
> 
> If we don’t explicitly check for ‘h’ in troff, we can’t reliably check
> for non-htmlroff well.
> 
> Consider the following:
> 
> 	.if h \{\
> 	.	de M
> 	.		tm m
> 	..\}
> 
> Without this change, this will print m and not define macro M.
> ---
> diff 24b9a78ceb63234ef0b0e7d1da0d46119b7a297d c2f89dc6c142284fc3b4c38a4e9fbf5c0c5b2a1d
> --- a/sys/src/cmd/troff/n5.c	Wed Nov 24 15:41:36 2021
> +++ b/sys/src/cmd/troff/n5.c	Wed Nov 24 20:56:44 2021
> @@ -683,6 +683,7 @@
>   		if (TROFF)
>   			true++;
>   		break;
> +	case 'h':
>   	case ' ':
>   		break;
>   	default:
> 

Generally looks ok to me, but I'm not a troff expert.
Was hoping someone a bit more knowlegable would look,
but I'm willing to commit if nobody else pipes up.

thanks for pinging.