* [9front] sys/src/cmd/gs/spim.h should not be checked in?
@ 2024-05-29 22:22 James Cook
2024-05-30 20:42 ` qwx
0 siblings, 1 reply; 3+ messages in thread
From: James Cook @ 2024-05-29 22:22 UTC (permalink / raw)
To: 9front
Hi,
On a fresh install from a recent nightly*, git/diff (after
cd /; bind -ac /dist/plan9front /; git/fs) includes this hunk:
--- a/sys/src/cmd/gs/spim.h
+++ b/sys/src/cmd/gs/spim.h
@@ -1,3 +1,3 @@
-#include "mips.h"
+#include "default.mips.h"
#undef ARCH_IS_BIG_ENDIAN
#define ARCH_IS_BIG_ENDIAN 0
It looks like the mkfile generates spim.h by copying default.spim.h
and so unless I'm missing something spim.h should just not be checked
in.
(The only other hunk in git/diff output is is adding bootflile= to
/sys/lib/dist/cfg/plan9.ini which makes sense.)
--
James
* https://iso.only9fans.com/9front/9front-10595.amd64.iso.gz
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [9front] sys/src/cmd/gs/spim.h should not be checked in?
2024-05-29 22:22 [9front] sys/src/cmd/gs/spim.h should not be checked in? James Cook
@ 2024-05-30 20:42 ` qwx
2024-06-06 10:36 ` qwx
0 siblings, 1 reply; 3+ messages in thread
From: qwx @ 2024-05-30 20:42 UTC (permalink / raw)
To: 9front
On Thu May 30 00:22:22 +0200 2024, falsifian@falsifian.org wrote:
> Hi,
>
> On a fresh install from a recent nightly*, git/diff (after
> cd /; bind -ac /dist/plan9front /; git/fs) includes this hunk:
>
> --- a/sys/src/cmd/gs/spim.h
> +++ b/sys/src/cmd/gs/spim.h
> @@ -1,3 +1,3 @@
> -#include "mips.h"
> +#include "default.mips.h"
> #undef ARCH_IS_BIG_ENDIAN
> #define ARCH_IS_BIG_ENDIAN 0
>
> It looks like the mkfile generates spim.h by copying default.spim.h
> and so unless I'm missing something spim.h should just not be checked
> in.
>
> (The only other hunk in git/diff output is is adding bootflile= to
> /sys/lib/dist/cfg/plan9.ini which makes sense.)
>
> --
> James
I think you're correct. If no one objects, we should git/rm it.
Thanks,
qwx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [9front] sys/src/cmd/gs/spim.h should not be checked in?
2024-05-30 20:42 ` qwx
@ 2024-06-06 10:36 ` qwx
0 siblings, 0 replies; 3+ messages in thread
From: qwx @ 2024-06-06 10:36 UTC (permalink / raw)
To: 9front
On Thu May 30 22:44:21 +0200 2024, qwx@sciops.net wrote:
> On Thu May 30 00:22:22 +0200 2024, falsifian@falsifian.org wrote:
> > Hi,
> >
> > On a fresh install from a recent nightly*, git/diff (after
> > cd /; bind -ac /dist/plan9front /; git/fs) includes this hunk:
> >
> > --- a/sys/src/cmd/gs/spim.h
> > +++ b/sys/src/cmd/gs/spim.h
> > @@ -1,3 +1,3 @@
> > -#include "mips.h"
> > +#include "default.mips.h"
> > #undef ARCH_IS_BIG_ENDIAN
> > #define ARCH_IS_BIG_ENDIAN 0
> >
> > It looks like the mkfile generates spim.h by copying default.spim.h
> > and so unless I'm missing something spim.h should just not be checked
> > in.
> >
> > (The only other hunk in git/diff output is is adding bootflile= to
> > /sys/lib/dist/cfg/plan9.ini which makes sense.)
> >
> > --
> > James
>
> I think you're correct. If no one objects, we should git/rm it.
>
> Thanks,
> qwx
Applied, thanks.
Cheers,
qwx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-06 10:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-29 22:22 [9front] sys/src/cmd/gs/spim.h should not be checked in? James Cook
2024-05-30 20:42 ` qwx
2024-06-06 10:36 ` qwx
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).