Re: [9front] [PATCH] rio: allow spaces in working directory path (-cd) when creating a new window

[igor@9lab.org]

Thanks for looking over it!

Quoth cinap_lenrek@felloff.net:
[…]
> probably is better to parse everything using gettokens().
> as your patch doesnt handle quoting the quotes.
[…]

Thanks for the tip. That indeed sounds like the cleaner solution.

> the whole window command also will probably have issues with
> this kind of stuff... the quoting is definitely messed up in
> there.

Yeah, that is where my journey started, thinking that window cmd
was the culprit, until I realised that the limitation goes all
the way to `/sys/src/cmd/rio/wctl.c:/^parsewctl`.

> 
> tho it is possible to quote from rc, like:
> 
> fn q {a=$1 whatis a | sed 's!^a=!!;q'}
> 
> or even get rid of wctl all together... it is a bit silly given
> you can just fork and mount $wsys yourself... then there are not
> two different code paths for creating a window.

I think I understand what you mean. The below is just checking I am
on the same page.

You are referring to the two highlighted ('^^^') code paths in
/rc/bin/window:

…
  if(~ $#mflag 1) {
  ^^^
  	…
  		if(mount $wsys /mnt/wsys 'new '$"spec){
  			bind -b /mnt/wsys /dev
  			exec $argv0 -x $cmd </dev/cons >/dev/cons >[2]/dev/cons
  		}
  	}&
  	exit ''
  }
  if not {
  ^^^  	if(~ $wctl ''){
  		if(test -f /dev/wctl) wctl=/dev/wctl
  		if not if(test -f /mnt/term/dev/wctl) wctl=/mnt/term/dev/wctl
  		if not if(test -r /mnt/term/env/wctl) wctl=/mnt/term^`{cat /mnt/term/env/wctl}
  		if not {
  			echo $argv0: '$wctl' not defined >[1=2]
  			exit bad
  		}
  	}
  
  	if(! ~ $#wdir 0)
  		spec=($spec -cd $wdir)
  	echo new $spec $argv0 -x $cmd >>$wctl
  }
…

…if I understand you correctly the suggestion is to drop the `if not  { … }`
part that writes to $wctl and modify the `if(~ $#mflag 1) { … }` in
such a way that it can handle both the `-m` and non `-m` variant.

Cheers,
Igor