[9front] eenter with select/snarf/paste

[9front] eenter with select/snarf/paste

[sirjofri]

Hi all,

I'm using eenter in my spreadsheet program for basically every line input. Some user asked for snarf/paste because that's not supported by eenter yet. Changing eenter wouldn't be a small change, so I wanted to ask first if that change would be accepted to 9front? Otherwise I'll just copy the function to the spread package and add the features there.

Have a good day

sirjofri

Re: [9front] eenter with select/snarf/paste

[Jacob Moody]

On 7/16/24 09:31, sirjofri wrote:
> Hi all,
> 
> I'm using eenter in my spreadsheet program for basically every line input. Some user asked for snarf/paste because that's not supported by eenter yet. Changing eenter wouldn't be a small change, so I wanted to ask first if that change would be accepted to 9front? Otherwise I'll just copy the function to the spread package and add the features there.

What would be the mechanism for a user to communicate to the eenter input prompt that they want use the snarf buffer?
Would it be mouse chording? Or perhaps a mouse menu on the input box itself with paste as an option?
I would personally be fine with adding this feature as long the added code doesn't make too much of a mess.
I would also probably expect the libthread variant, enter() in mouse(2), to also be updated to this new functionality.


Thanks,
moody

Re: [9front] eenter with select/snarf/paste

[sirjofri]

16.07.2024 16:48:49 Jacob Moody <moody@posixcafe.org>:

> On 7/16/24 09:31, sirjofri wrote:
>> Hi all,
>>
>> I'm using eenter in my spreadsheet program for basically every line input. Some user asked for snarf/paste because that's not supported by eenter yet. Changing eenter wouldn't be a small change, so I wanted to ask first if that change would be accepted to 9front? Otherwise I'll just copy the function to the spread package and add the features there.
>
> What would be the mechanism for a user to communicate to the eenter input prompt that they want use the snarf buffer?
> Would it be mouse chording? Or perhaps a mouse menu on the input box itself with paste as an option?
> I would personally be fine with adding this feature as long the added code doesn't make too much of a mess.
> I would also probably expect the libthread variant, enter() in mouse(2), to also be updated to this new functionality.

Mouse chording would make most sense to me, given that this is commonly used throughout the system.

I'll take a look at the libthread variant, maybe they are similar enough to share code, at least structure-wise. I'll see what I can do and send a patch, ETA in the next few days.

sirjofri

Re: [9front] eenter with select/snarf/paste

[Scott Flowers]

Hi. I'm "some user" that sirjofre referred to. I was just thinking mouse chording inside the data entry boxes would make sense and be useful.

My two cents.

Scott Flowers
flowerss@cranky.ca

On Tue, 16 Jul 2024, at 10:51, sirjofri wrote:
> 16.07.2024 16:48:49 Jacob Moody <moody@posixcafe.org>:
> 
> > On 7/16/24 09:31, sirjofri wrote:
> >> Hi all,
> >>
> >> I'm using eenter in my spreadsheet program for basically every line input. Some user asked for snarf/paste because that's not supported by eenter yet. Changing eenter wouldn't be a small change, so I wanted to ask first if that change would be accepted to 9front? Otherwise I'll just copy the function to the spread package and add the features there.
> >
> > What would be the mechanism for a user to communicate to the eenter input prompt that they want use the snarf buffer?
> > Would it be mouse chording? Or perhaps a mouse menu on the input box itself with paste as an option?
> > I would personally be fine with adding this feature as long the added code doesn't make too much of a mess.
> > I would also probably expect the libthread variant, enter() in mouse(2), to also be updated to this new functionality.
> 
> Mouse chording would make most sense to me, given that this is commonly used throughout the system.
> 
> I'll take a look at the libthread variant, maybe they are similar enough to share code, at least structure-wise. I'll see what I can do and send a patch, ETA in the next few days.
> 
> sirjofri
> 

Re: [9front] eenter with select/snarf/paste

[sirjofri]

16.07.2024 16:48:49 Jacob Moody <moody@posixcafe.org>:
> I would also probably expect the libthread variant, enter() in mouse(2), to also be updated to this new functionality.

I compared both variants and they have roughly the same code structure. It would be possible to share the same code by extracting functionality to separate auxiliary functions. However...

> I would personally be fine with adding this feature as long the added code doesn't make too much of a mess.

...this would mean quite some code restructuring. While this will not necessarily end up being a mess, it will result in having ~5 functions instead of just 2.

This will have its upsides and downsides like usual, especially considering future code changes and maintenance. Instead of touching the same code in two different functions twice, it means changing the code only once and having the functionality in both.

I'll see what I can do. For now, I can select text and delete it (backspace and "overtype", if that's a word in this context), and it doesn't react to all mouse buttons so I can chord.

When it's done, I'll need people for testing, especially considering runes and UTF8 character lengths, plus code feedback obviously.

sirjofri

Re: [9front] eenter with select/snarf/paste

[umbraticus]

tangential, but perhaps something to consider in
any rejigging: I recently noticed that clicking
in the prompt part of (e)enter's rectangle is
equivalent to hitting enter. I can see some benefit;
maybe speeds up accepting default string repeatedly
without reaching to the keyboard (eg text search
in mothra). Downside: one can accidentally trigger
it when trying to position cursor at start of the
typing part of the rectangle. Not sure whether this
has delighted or disturbed anyone else.

I am for enabling chording in enter. Double-click at
start or end could select all? a la line select elsewhere.

umbraticus

Re: [9front] eenter with select/snarf/paste

[sirjofri]

17.07.2024 15:30:56 umbraticus@prosimetrum.com:
> tangential, but perhaps something to consider in
> any rejigging: I recently noticed that clicking
> in the prompt part of (e)enter's rectangle is
> equivalent to hitting enter. I can see some benefit;
> maybe speeds up accepting default string repeatedly
> without reaching to the keyboard (eg text search
> in mothra). Downside: one can accidentally trigger
> it when trying to position cursor at start of the
> typing part of the rectangle. Not sure whether this
> has delighted or disturbed anyone else.

It's currently disturbing me while testing. My thinkpad buttons aren't 100% precise, so sometimes a single click is recognized as two clicks, in which case the prompt opens and immediately closes.

sirjofri

Re: [9front] eenter with select/snarf/paste

[thedaemon]

Quoth sirjofri <sirjofri+ml-9front@sirjofri.de>:
> 17.07.2024 15:30:56 umbraticus@prosimetrum.com:
> > tangential, but perhaps something to consider in
> > any rejigging: I recently noticed that clicking
> > in the prompt part of (e)enter's rectangle is
> > equivalent to hitting enter. I can see some benefit;
> > maybe speeds up accepting default string repeatedly
> > without reaching to the keyboard (eg text search
> > in mothra). Downside: one can accidentally trigger
> > it when trying to position cursor at start of the
> > typing part of the rectangle. Not sure whether this
> > has delighted or disturbed anyone else.
> 
> It's currently disturbing me while testing. My thinkpad buttons aren't 100% precise, so sometimes a single click is recognized as two clicks, in which case the prompt opens and immediately closes.
> 
> sirjofri
I very much dislike not being able to snarf in eenter. 
Sign me up for testing.

thedæmon

Re: [9front] eenter with select/snarf/paste

[ori]

Quoth sirjofri <sirjofri+ml-9front@sirjofri.de>:
> Hi all,
> 
> I'm using eenter in my spreadsheet program for basically every line input. Some user asked for snarf/paste because that's not supported by eenter yet. Changing eenter wouldn't be a small change, so I wanted to ask first if that change would be accepted to 9front? Otherwise I'll just copy the function to the spread package and add the features there.
> 
> Have a good day
> 
> sirjofri

yes please

Re: [9front] eenter with select/snarf/paste

[sirjofri]

Hello all,

I prepared a small testing program to gather user feedback. You can download the binary here: https://sirjofri.de/oat/tmp/6.eenter (amd64, obviously). It uses eenter as I started with it.

I'll try to share the source asap. Code needs cleanup and restructuring as I preferably want to share as much code as usefully possible between enter and eenter.

Regarding the snarf/paste behavior: I tried to match the natural behavior as close as possible, but some things aren't the same. For example, acme seems to have another separate snarf buffer, which I never really use, it seems to be related with undo in a 1-3-5-3 chain (100-110-101-110), where the last interaction doesn't paste, but undoes the whole operation. I don't think it makes sense to go that far for (e)enter.

Feedback and bug reports are welcome.

Edit: Here's the code: https://shithub.us/sirjofri/eesp (eenter snarf paste). Note that I don't like the code as-is, no need for code feedback yet. In case you want to test it, make sure to do a backup first or revert later).

sirjofri

Re: [9front] eenter with select/snarf/paste

[sirjofri]

20.07.2024 17:03:28 sirjofri <sirjofri+ml-9front@sirjofri.de>:
> Edit: Here's the code: https://shithub.us/sirjofri/eesp (eenter snarf paste).

I updated the code to have one generic function for both enter and eenter. At this point I'm also happy for feedback on the code.

This adds genenter.(c|h) inside libdraw. The helper functions could still be improved.

The package "installs" over your system libdraw implementation. You'll have to backup enter.c, eenter.c and mkfile (or revert) manually.

What do you think?

sirjofri