From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.0 required=5.0 tests=T_SCC_BODY_TEXT_LINE
	autolearn=ham autolearn_force=no version=3.4.4
Received: (qmail 8020 invoked from network); 22 May 2022 23:25:47 -0000
Received: from 9front.inri.net (168.235.81.73)
  by inbox.vuxu.org with ESMTPUTF8; 22 May 2022 23:25:47 -0000
Received: from mimir.eigenstate.org ([206.124.132.107]) by 9front; Sun May 22 19:24:14 -0400 2022
Received: from abbatoir.myfiosgateway.com (pool-74-108-56-225.nycmny.fios.verizon.net [74.108.56.225])
	by mimir.eigenstate.org (OpenSMTPD) with ESMTPSA id eba7ce08 (TLSv1.2:ECDHE-RSA-AES256-SHA:256:NO)
	for <9front@9front.org>;
	Sun, 22 May 2022 16:24:06 -0700 (PDT)
Message-ID: <833445198A71E1A330A18CFA1427A21A@eigenstate.org>
To: 9front@9front.org
Date: Sun, 22 May 2022 19:24:05 -0400
From: ori@eigenstate.org
In-Reply-To: <399c430d-65da-0c60-e046-38c19f7c6305@posixcafe.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: managed self-healing SOAP over ACPI factory high-performance layer 
Subject: Re: [9front] [PATCH] diff: retain original file names
Reply-To: 9front@9front.org
Precedence: bulk

Quoth Jacob Moody <moody@mail.posixcafe.org>:
> On 5/22/22 10:41, Ori Bernstein wrote:
> > 
> > When diffing non-regular files, like /dev/null,
> > pipes, and similar, diff will generate a temp
> > file to diff against. This is the right thing
> > to do, but the temp file leaks into the diff.
> > 
> > This patch retains the original file name all
> > the way through to diff output.
> 
> This has been a pet peeve of mine, glad to see
> I wasn't the only one. Looks good to me! One
> small comment inline that I could take or leave.
> 

pushed, fixed comment in separate commit.

thanks!