From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 13682 invoked from network); 22 Dec 2020 13:05:10 -0000
Received: from ewsd.inri.net (107.191.116.128)
  by inbox.vuxu.org with ESMTPUTF8; 22 Dec 2020 13:05:10 -0000
Received: from mail-wm1-f50.google.com ([209.85.128.50]) by ewsd; Tue Dec 22 07:57:46 -0500 2020
Received: by mail-wm1-f50.google.com with SMTP id g25so1582395wmh.1
        for <9front@9front.org>; Tue, 22 Dec 2020 04:57:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=from:message-id:to:subject:date:in-reply-to:mime-version
         :content-transfer-encoding;
        bh=PeJDrCsMmr8/lCagtReTX+ThIHUDEkQNim/5WKhY2qs=;
        b=r2kT+IHMehJbomXdsrrStWzGQGrhCsHH3oqB9u39wvTlPd2rCDs4dSrtrm9R+nZfci
         XShaYU/iD1/OeOMZNNwriC80AaQ95IrStKI8WQ08EQ6rBJJitPGfjTTw9DUo7FIBYxMx
         1Ccmdn+A/vImL18t4pXoJbRTjaW23nbFh9h4cwDSMt7bNcrAzwC/DAqEdFxjl1p/tcFF
         Z8VqOTF012riVIa/fE7GVdLLlBdE4YSSpxe1+2+/2gRaAdZQQERtnbNXNtZSWft8dbyK
         Uj6PvYZdzFiBqOexjGaCIkAhoPuMy8WZ25y/XpyJMTPrG90P14pLn5kz1zm1Vs3RggVR
         8IQQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:from:message-id:to:subject:date:in-reply-to
         :mime-version:content-transfer-encoding;
        bh=PeJDrCsMmr8/lCagtReTX+ThIHUDEkQNim/5WKhY2qs=;
        b=S7Y90d3XfxnLGunoGGko4IHdmTLN2pcFtvvJDe8HGmk9hOale/DjuQM4HExXRHkSRe
         skzWOFHur5AZAGAdXvr0f/G5ZU+7EFhvtr162ZmM3Rx3wGH5wMBEiewlNboW73gK73WI
         417JVFYByQtOcOgXC15IPi+0V8j79o/W8Pc5cLCaasLXE1wu2ol839o4mSTov/PvvZIe
         DJ9EHzN89KIttnwYAwxz8k4iqAuUCxO+MKkRKEfRZ5nTBk8A6WGaFdbPIhmfVZ+5EGWo
         sjldzBboweAsi2eim0AFhw0Q6ZzVJrwdNakIBkjRKd3Md4evYHrjjvAHnR4KNQv6iU3D
         wDXA==
X-Gm-Message-State: AOAM53128zgulCyo+Z6ZP1le/UJfMaVfsrY6u1cDGlNFK1GWCCb2eiy2
	OmV8dDHmz7tnai5avj0gReITqcmZ1V0=
X-Google-Smtp-Source: ABdhPJx2QRoAa9Dz9f3sRwWiMkHdt1mKtLdqQr8L08CpE3KEf+sQYb0s2KfYjcfO0zVWdcEfifLCwA==
X-Received: by 2002:a05:600c:224b:: with SMTP id a11mr21569314wmm.97.1608641863463;
        Tue, 22 Dec 2020 04:57:43 -0800 (PST)
Return-Path: <boehm.igor@gmail.com>
Received: from cirno.home ([185.64.155.70])
        by smtp.gmail.com with ESMTPSA id n11sm13086955wra.9.2020.12.22.04.57.42
        for <9front@9front.org>
        (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256);
        Tue, 22 Dec 2020 04:57:42 -0800 (PST)
From: boehm.igor@gmail.com
X-Google-Original-From: igor@gmail.com
Message-ID: <8346FB2C661CAB4E1B93DBA3EE06E0B9@gmail.com>
To: 9front@9front.org
Date: Tue, 22 Dec 2020 13:57:41 +0100
In-Reply-To: <84F5C7BED2BA9DFEABB969E4E8E00C58@prosimetrum.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: ORM deep-learning callback callback generator 
Subject: Re: [9front] kbdfs broken after new kernel build
Reply-To: 9front@9front.org
Precedence: bulk

The diff has added a static variable 'user' to the fillstat() function:

1.6 char *mntpt = "/dev";
1.7+char *user;
...
1.37 static int
1.38 fillstat(ulong qid, Dir *d)
1.39 {
1.40+	static char *user;
     	^^^^^^^^^^^^^^^^^^
1.41 	struct Qtab *t;
1.42 
1.43 	memset(d, 0, sizeof *d);
1.44-	d->uid = getauser();
1.45-	d->gid = getauser();
1.46+	d->uid = d->gid = user;

The function static variable user shadows the global user variable and is not being initialised:

kbdfs.c:107 char *user;
...
kbdfs.c:1257 static int
kbdfs.c:1258 fillstat(ulong qid, Dir *d)
kbdfs.c:1259 {
kbdfs.c:1260 	static char *user;
             	^^^^^^^^^^^^^^^^^^
kbdfs.c:1261 	struct Qtab *t;
kbdfs.c:1262 
kbdfs.c:1263 	memset(d, 0, sizeof *d);
kbdfs.c:1264 	d->uid = d->gid = user;
             	^^^^^^^^^^^^^^^^^^^^^^^

Maybe line 'kbdfs.c:1260' is the culprit?

Cheers,
Igor

> err, rather, this change:
> 
> changeset:   8191:8eefeaac58c7
> user:        cinap_lenrek@felloff.net
> date:        Sat Dec 19 15:52:41 2020 +0100
> summary:     aux/kbdfs: use getuser() from libc
> 
> can confirm that hg revert -r 8a74c22c68dd kbdfs.c fixes the problem.
> 
> umbraticus