From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_ADSP_CUSTOM_MED,
	DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.4
Received: (qmail 6696 invoked from network); 25 Nov 2023 00:29:23 -0000
Received: from 9front.inri.net (168.235.81.73)
  by inbox.vuxu.org with ESMTPUTF8; 25 Nov 2023 00:29:23 -0000
Received: from mail-oa1-f49.google.com ([209.85.160.49]) by 9front; Fri Nov 24 19:27:49 -0500 2023
Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-1f066fc2a2aso1237197fac.0
        for <9front@9front.org>; Fri, 24 Nov 2023 16:27:46 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1700872066; x=1701476866; darn=9front.org;
        h=content-transfer-encoding:in-reply-to:content-language:references
         :to:subject:user-agent:mime-version:date:message-id:from:from:to:cc
         :subject:date:message-id:reply-to;
        bh=DQMzqQII07Cs3N8cFOs0R7k+iKMnWBdY0zDmZLT+meg=;
        b=XLvhFCnyY6csbEbIOoXLl9jrGQjUW2f2JfAEVU9o40+yR0dxucbqzAOlOdP0uHvt4X
         O9vQ2faMLjY1y1sBG4K5/FwK9xAZm4iK42XZfV8VFArSHuZ23xiSKkUHuACfJqcHLmsE
         cx4StOFM1hj7Yr784ZOTrlXXLNlG404YNg8q3GZMW2Xz6xnAatQimtgxTF/Qfs5qO5b1
         JbrJ/SLJORF/z8hd2TG/XJwgVcdBRvh3nUeKE2uCv3xVL8Iz/bpMCW+oHmzzo4MaD3df
         8NL4UCSPFzjB/n1gfIJnqaXe/SxBvGK0uVkcgzcNUL/NUUNTFm+iLsMHSs9DAuXZSb/X
         2uFA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1700872066; x=1701476866;
        h=content-transfer-encoding:in-reply-to:content-language:references
         :to:subject:user-agent:mime-version:date:message-id:from
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=DQMzqQII07Cs3N8cFOs0R7k+iKMnWBdY0zDmZLT+meg=;
        b=C2NiI4vWEC6gdwI4fvFxsXvI159mmTKegKK1AqOOJbcUR3kYk1gaRO1wflT94j9C4R
         HQyisgXUItwE66DG8kM245MzXWNwUkxLaPKyncIeUN+FDrbvpY3IcNgnWcIDlDDl1+nZ
         +9NN/ls6OZDaPAdV0BKb+izlsQME4Z99Qj3+cb/pG0dxHbud/xYeQZgf02U3+9SDCvtE
         5VtwL/UuazUcXMfXwL/IhP3lFRnLFnBjPYZpYG5f0H17PrUmBLPwly+57Y3Hm7bp/Jho
         +giAR8Lq98YZLSUjCE3fJqJsNDANCfZg3SWJoeBtl5P6TlMtjSgwuU/VNX0j3XZHv65h
         VPGA==
X-Gm-Message-State: AOJu0Yzxb0tBZzPA+Gt0KYVBkzPMz9sBGGMoFFGpEVKf7psRt3exSlY0
	Ff4WeBm6l2SfkAQ4fvHmt/dWWQmt2WxayQ==
X-Google-Smtp-Source: AGHT+IErku7lye8ZtJHun2u1kV7fNXIxQrGZ1b0XSWxr46WbCTArA6idpIJbY+beQjnlgPbzOTV0AQ==
X-Received: by 2002:a05:6871:520f:b0:1fa:4bd:97dd with SMTP id ht15-20020a056871520f00b001fa04bd97ddmr3600889oac.26.1700872065602;
        Fri, 24 Nov 2023 16:27:45 -0800 (PST)
Return-Path: <bluemanedhawk@gmail.com>
Received: from ?IPV6:2600:1700:e4c0:9ea0::5f6? ([2600:1700:e4c0:9ea0::5f6])
        by smtp.gmail.com with ESMTPSA id l25-20020a056830335900b006d7f8da1b57sm674571ott.62.2023.11.24.16.27.44
        for <9front@9front.org>
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Fri, 24 Nov 2023 16:27:45 -0800 (PST)
From: Blue-Maned_Hawk <bluemanedhawk@gmail.com>
X-Google-Original-From: Blue-Maned_Hawk <bluemanedhawk@invalid.invalid>
Message-ID: <8708ecaa-0b89-430d-ad06-2fd272680660@invalid.invalid>
Date: Fri, 24 Nov 2023 19:27:43 -0500
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: 9front@9front.org
References: <904397cf-6c3f-46c4-9139-7f80823ec064@invalid.invalid>
 <4eeba9d4-12f2-4938-b0b3-5a8404653282@posixcafe.org>
Content-Language: en-US
In-Reply-To: <4eeba9d4-12f2-4938-b0b3-5a8404653282@posixcafe.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: non-blocking session pipelining engine app 
Subject: Re: [9front] [PATCH] Fix assert macro to not break on commas
Reply-To: 9front@9front.org
Precedence: bulk

On 11/22/23 23:20, Jacob Moody wrote:
> On 11/22/23 17:11, Blue-Maned_Hawk wrote:
>> This is a pair of patches that changes the assert macro to be variadic,
>> allowing expressions with commas in them to be used without needing a
>> spare pair of parentheses, and updates the manpage accordingly.
>> 
> 
> For what reason does this need changed?

To avoid (admittedly, edge) cases where a comma in the expression being 
asserted would be incorrectly interpretted as an attempt to invoke a 
single-argument macro with two or more arguments.

> Is there some code you're working with expecting this?

No.

> I am inclined to prefer to keep this as is.

Why?