Re: [9front] ape/bsd: Enable setting the local address with bind

[Benjamin Riefenstahl <b.riefenstahl@turtle-trading.net>]

Hi Ori,


Ori writes:
> Apologies for taking so long to respond. Life got busy, and I forgot.

No problem.  I often take my time myself ;-) Thanks for looking at it
now.  Note that this is some time ago for me now, too, so I may remember
wrongly how and why I did things and I will have to redo the tests.

> This looks like it's attempting (incorrectly?) to implement
> INADDR_ANY, binding to any ip address. However, INADDR_ANY is 0:
>
> 	/sys/include/ape/netinet/in.h:98:
> 		#define	INADDR_ANY		(unsigned long)0x00000000

As far as I can tell, using IP address INADDR_ANY and using port 0 to
indicate that the IP stack should choose the actual number both work
with the native control commands, so they do not need much special care
here.

> And I see no specification that describes what should be done with
> negative ports in the sockets world, so I can only assume that this is
> a bug.

I/we should probably just make negative ports an error. 

> I don't think 'bind *' should be removed, since it seems to me that it
> works as intended for binding to all addresses, but the ape userspace
> for it is wrong.

When I tried this a long time ago, when this was called it just returned
errors.  INADDR_ANY just works, I think, so there does not seem to be a
reason for this special handling.

I will have to create some test cases to see what works and what
doesn't.

>> The documentation in the man page ip(3) for the control commands
>> "bind" and "announce" does not mention the local address, should that
>> be fixed, too?

> Yes, that would be wonderful.

Another one for the todo list then  ;-)


Thanks, benny