From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 19042 invoked from network); 6 Oct 2021 22:30:22 -0000
Received: from 4ess.inri.net (216.126.196.42)
  by inbox.vuxu.org with ESMTPUTF8; 6 Oct 2021 22:30:22 -0000
Received: from mimir.eigenstate.org ([206.124.132.107]) by 4ess; Wed Oct  6 18:18:32 -0400 2021
Received: from abbatoir.myfiosgateway.com (pool-74-108-56-225.nycmny.fios.verizon.net [74.108.56.225])
	by mimir.eigenstate.org (OpenSMTPD) with ESMTPSA id dc7ea7e3 (TLSv1.2:ECDHE-RSA-AES256-SHA:256:NO)
	for <9front@9front.org>;
	Wed, 6 Oct 2021 15:17:52 -0700 (PDT)
Message-ID: <897F3C9BF1DCFC73743906693B752216@eigenstate.org>
To: 9front@9front.org
Date: Wed, 06 Oct 2021 18:17:50 -0400
From: ori@eigenstate.org
In-Reply-To: <1dc852446d8cbfbbed587804c5b3f401f2146813.camel@biobuf.link>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: content-driven app app 
Subject: Re: [9front] [PATCH] acme: don't let tag button draw over tag border.
Reply-To: 9front@9front.org
Precedence: bulk

Looks good to me. Committing.

Quoth james palmer <james@biobuf.link>:
> this fixes the apperance of a 2px wide gap between the edge of the tag
> button and the start of the bottom border by making the tag button 2px
> less wide rather than shrinking it's rectange after creating the image.
> 
> from this plan9port pull request:
> https://github.com/9fans/plan9port/pull/490
> 
> - james


> From: james palmer <james@biobuf.link>
> Date: Wed, 06 Oct 2021 09:19:58 +0000
> Subject: [PATCH] acme: don't let tag button draw over tag border.

Just as a heads up, you can just mail this
out directly. rather than doing the email
in an email thing.

	git/export | mail 9front@9front.org

you can also use a diff and write up an
email:

	write email in your favorite client
	git/diff >/dev/snarf
	paste into client

git/import knows how to handle both cases;
the subject+body of the email will become
the commit message, and the patch will be
applied.

	git/import /mail/fs/55153/

maybe we should add a way to add a preamble
or explanatory comment to the email.

> ---
> diff 6ebb8b9e357944cc29ae3fafc0900ee3e325ed39
> 2134a2c638e2668f45a92ec814326689cc8089c3
> --- a/sys/src/cmd/acme/acme.c	Sun Oct  3 16:58:58 2021
> +++ b/sys/src/cmd/acme/acme.c	Wed Oct  6 10:19:58 2021
> @@ -895,16 +895,14 @@
>  		freeimage(colbutton);
>  	}
>  
> -	r = Rect(0, 0, Scrollwid+2, font->height+1);
> +	r = Rect(0, 0, Scrollwid, font->height+1);
>  	button = allocimage(display, r, screen->chan, 0, DNofill);
>  	draw(button, r, tagcols[BACK], nil, r.min);
> -	r.max.x -= 2;
>  	border(button, r, 2, tagcols[BORD], ZP);
>  
>  	r = button->r;
>  	modbutton = allocimage(display, r, screen->chan, 0, DNofill);
>  	draw(modbutton, r, tagcols[BACK], nil, r.min);
> -	r.max.x -= 2;
>  	border(modbutton, r, 2, tagcols[BORD], ZP);
>  	r = insetrect(r, 2);
>  	tmp = allocimage(display, Rect(0,0,1,1), screen->chan, 1,
> DMedblue);
> 
>