From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mimir.eigenstate.org ([206.124.132.107]) by ewsd; Sat Oct 24 20:25:38 -0400 2020
Received: from abbatoir.fios-router.home (pool-74-101-2-6.nycmny.fios.verizon.net [74.101.2.6])
	by mimir.eigenstate.org (OpenSMTPD) with ESMTPSA id 44b3da2d (TLSv1.2:ECDHE-RSA-AES256-SHA:256:NO);
	Sat, 24 Oct 2020 17:25:27 -0700 (PDT)
Message-ID: <8A4FF83D2A57710F500A4C0F3915387C@eigenstate.org>
To: covertusername967@gmail.com, 9front@9front.org
Subject: Re: [9front] libmp and error handling
Date: Sat, 24 Oct 2020 17:25:26 -0700
From: ori@eigenstate.org
In-Reply-To: <D83DF21805452CD642F40CAA16999ADD@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: proven software ACPI over SQL engine CSS engine persistence layer 

>> This is still likely to require quite a bit of change in libmp; if
>> it's currently calling sysfatal, then it's very likely full of
>> things like:
>> 
>> 	x = a();
>> 	y = b()
>> 	return mpadd(x, y);
>> 
>> which means that if b() errors, then x is leaked.
> 
> So, I tried changing libmp itself.  It rapidly became a hairy mess of
> return checking, and making the library do more allocation just to
> preserve the original function arguments.  Instead, here's a patch to
> fix the manpage:

Thanks, committed.