From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from out1.migadu.com ([91.121.223.63]) by ewsd; Fri Nov 20 15:04:16 -0500 2020
Message-ID: <95033F0DC59EE5B31D4E5AA44277FD09@hog>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=a-b.xyz; s=key1;
	t=1605902676;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:  in-reply-to:in-reply-to;
	bh=dzhWLDxVAGcFAkuE8sMnv91EDxCdyV5mrGtrNaGI/PU=;
	b=vq1jCHWZk02ThDKswNv3ktzkGatgqXdc9/hkgkN8mStCR+rNg8fdvl2H6olVUXJCRIUSou
	L2ApsomW9I98oMA6tGuZzMWgwW0crJVK87xnQPYyWs6ozTNR0U9RurFjdncZ22WXyax8Ld
	DaoYtKTRmC4I7Y+mIV7OY6xZ5dMw9WUd95aFKg3k4DzTqhtXk/tfhut4KdeIIo2/t3BoT8
	r30agTHPl+DGvueOFwYkdXVuEbSeFubgoCKUKmO7hNZR/f9hg/O8qp4STr7p0PSMV5S1XC
	koh93b6k7jQdcm75Wad+7vDKChD+PlIGci1M1lnicRHXhZyX7FP1nA0sD2l+iw==
To: 9front@9front.org
Subject: Re: [9front] [PATCH] libndb: remove database size limit
Date: Fri, 20 Nov 2020 21:04:04 +0100
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
From: kvik@a-b.xyz
In-Reply-To: <5CD8AF11CB98A58E8F7A944615EC5C2C@a-b.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.40
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: lossless session interface property backend 

Bump.

Repeating patch and message for your convenience:

Libndb enforces a 128k size limit on unhashed database files.
Files exceeding the limit are ignored and complaints are issued.
This seems... suboptimal.

The following patch removes the limit.

diff -r 5ca47d85e288 sys/src/libndb/ndbhash.c
--- a/sys/src/libndb/ndbhash.c	Mon Sep 21 11:43:31 2020 -0700
+++ b/sys/src/libndb/ndbhash.c	Mon Sep 21 22:10:06 2020 +0200
@@ -142,17 +142,6 @@
 		}
 		s->ptr = NDBGETP(p);
 		s->type = Cptr1;
-	} else if(db->length > 128*1024){
-		print("Missing or out of date hash file %s.%s.\n", db->file, attr);
-		syslog(0, "ndb", "Missing or out of date hash file %s.%s.", db->file, attr);
-
-		/* advance search to next db file */
-		s->ptr = NDBNAP;
-		_ndbcacheadd(db, s, attr, val, nil);
-		if(db->next == nil)
-			return nil;
-		t = ndbsearch(db->next, s, attr, val);
-		goto out;
 	} else {
 		s->ptr = 0;
 		s->type = Dptr;