9front - general discussion about 9front
 help / color / mirror / Atom feed
From: qwx@sciops.net
To: 9front@9front.org
Subject: Re: [9front] aux/wacom: possible race
Date: Wed, 15 Dec 2021 00:55:56 +0100	[thread overview]
Message-ID: <96C08F9AEB121C6E156203FD9451E723@wopr.sciops.net> (raw)
In-Reply-To: <5FA0662D627A99E4DF5914FDD6E872E7@wopr.sciops.net>

On Mon Dec  6 02:57:05 +0100 2021, qwx@sciops.net wrote:
> Hello,
> 
> I've been playing with aux/wacom and aux/tablet on x61t.
> aux/tablet often crashes with a `no concurrent reads, please'
> error mid-drawing.  From what I can tell both of these
> programs are early 9front additions.  Has anyone else seen
> these errors?
> 
> I think that the issue is that nothing prevents the .req
> field of each Reader from being modified at the same time
> as a read(2) comes in, so at some point a new read could
> check the field before sendout() can clear it.  The patch
> below seems to work.
> 
> What do you think?
> 
> Thanks,
> qwx

After testing, the errors no longer occur.  I believe
that this is the right fix, and have pushed it.

Cheers!
qwx

  parent reply	other threads:[~2021-12-15  0:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-06  2:50 qwx
2021-12-06  3:08 ` Stanley Lieber
2021-12-14 23:55 ` qwx [this message]
2021-12-15  0:00   ` Stanley Lieber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96C08F9AEB121C6E156203FD9451E723@wopr.sciops.net \
    --to=qwx@sciops.net \
    --cc=9front@9front.org \
    --subject='Re: [9front] aux/wacom: possible race' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).