From: cinap_lenrek@felloff.net
To: 9front@9front.org
Subject: Re: [9front] ip/torrent and private trackers
Date: Sat, 1 Feb 2014 10:38:30 +0100 [thread overview]
Message-ID: <99bc96c20c5164febf6392a52579a9a9@felloff.net> (raw)
In-Reply-To: <20140201042800.GA28628@iota.offblast.org>
pid is a horrible name for this. why do you not just initialize
peerid at the beginning to -NF9001- and when the argument gets
parsed, insert the string. so theres no need for temprary pid
variable. note, your code is broken right now.
you use memmove, but the string might be shorter than 8 chars.
you want to use strncpy or snprint or something here.
--
cinap
prev parent reply other threads:[~2014-02-01 9:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-01 4:28 Nick Owens
2014-02-01 9:38 ` cinap_lenrek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99bc96c20c5164febf6392a52579a9a9@felloff.net \
--to=cinap_lenrek@felloff.net \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).