From: thinktankworkspaces@gmail.com
To: 9front@9front.org
Subject: Re: [9front] rewrite gateway
Date: Sat, 29 Jan 2022 15:29:08 -0800 [thread overview]
Message-ID: <9A1213D77123F54FFF4763DF7F1B2014@gmail.com> (raw)
In-Reply-To: <90050617726D475C720E8A8581DA8945@felloff.net>
Quoth cinap_lenrek@felloff.net:
> found it. i could reproduce it on 386 when replying to a message.
>
> the issue was a classical double-free in msgshow(), calling
> Bterm() twite on wfd:
>
> 251c3cfd610abd169676852d301a2aa1267c0e57 acne/Mail: fix double-free (Bterm() in mesgshow())
> Hash: 251c3cfd610abd169676852d301a2aa1267c0e57
> Date: Sat Jan 29 21:50:03 CET 2022
> Author: cinap_lenrek <cinap_lenrek@felloff.net>
> Message: acne/Mail: fix double-free (Bterm() in mesgshow())
>
> --- .git/fs/object/2833aecc681aec9928c525fc2d8d023dbfe225bc/tree/sys/src/cmd/upas/Mail/comp.c
> +++ .git/fs/object/251c3cfd610abd169676852d301a2aa1267c0e57/tree/sys/src/cmd/upas/Mail/comp.c
> diff -u .git/fs/object/2833aecc681aec9928c525fc2d8d023dbfe225bc/tree/sys/src/cmd/upas/Mail/comp.c .git/fs/object/251c3cfd610abd169676852d301a2aa1267c0e57/tree/sys/src/cmd/upas/Mail/comp.c
> @@ -283,7 +283,6 @@
> break;
> Bterm(rfd);
> }
> - Bterm(wfd);
> }
> Bterm(wfd);
> fprint(c->addr, "$");
>
> --
> cinap
I really appreciate this. I feel retarded trying to debug this. If only I can spend the day
annoyingly looking over someone else's shoulders, as they debug navigate or just generally
use this OS.
I ran another sysupdate, mk install and rebooted. Looks like its working. Thanks again!
Much appreciation.
next prev parent reply other threads:[~2022-01-30 4:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 0:52 thinktankworkspaces
2022-01-28 19:07 ` cinap_lenrek
2022-01-28 21:10 ` thinktankworkspaces
2022-01-28 21:22 ` ori
2022-01-28 23:04 ` thinktankworkspaces
2022-01-29 13:14 ` hiro
2022-01-29 14:18 ` cinap_lenrek
2022-01-29 20:50 ` cinap_lenrek
2022-01-29 23:29 ` thinktankworkspaces [this message]
2022-01-29 23:40 ` thinktankworkspaces
2022-01-30 12:14 ` cinap_lenrek
2022-01-30 16:16 ` ori
2022-01-30 23:01 ` thinktankworkspaces
2022-01-29 14:29 ` cinap_lenrek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9A1213D77123F54FFF4763DF7F1B2014@gmail.com \
--to=thinktankworkspaces@gmail.com \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).