From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED
	autolearn=no autolearn_force=no version=3.4.4
Received: (qmail 23965 invoked from network); 20 Jan 2021 11:24:34 -0000
Received: from 1ess.inri.net (216.126.196.35)
  by inbox.vuxu.org with ESMTPUTF8; 20 Jan 2021 11:24:34 -0000
Received: from mail-pl1-f174.google.com ([209.85.214.174]) by 1ess; Wed Jan 20 05:57:16 -0500 2021
Received: by mail-pl1-f174.google.com with SMTP id s15so12308686plr.9
        for <9front@9front.org>; Wed, 20 Jan 2021 02:57:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=mforney-org.20150623.gappssmtp.com; s=20150623;
        h=message-id:to:subject:from:date:mime-version
         :content-transfer-encoding;
        bh=bjxbV6fG20hKxeY8o8NCAotgS7qxajx5psHXzded68c=;
        b=mxihp+qwMH2OlMH8zrZ/e6ENGbVRltKT4cqarv7ykXP0ItdNEQaSYvKNIONBRZEOku
         FLrvsv19C0acAxa7HuusPRG1JiuIpJxf4J4z06o+ixTMXgcvZv3QStuPA28aVSE/rFLe
         APlopmhahxay4EKPUC01zl8BTHNXGnw8XPXAJwOl9dkwl+T5u/bgjnrliyEYoq29Dgqw
         xVF/ijDaI1Rc+h7DgyR52r8FbMFrdZ17IMo0fvEQ8QAw1EsLNl64XyM6MucbF58wvULU
         lzcjSBvGGGjy1Fs5zF+Abz42ZbovHzW/ZbnYC2uvsDQIYZRf0+qA23W7/fnlumNCXFuk
         hOFQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:message-id:to:subject:from:date:mime-version
         :content-transfer-encoding;
        bh=bjxbV6fG20hKxeY8o8NCAotgS7qxajx5psHXzded68c=;
        b=LjHOSBO8zM30C6qjwLJEUhUB/IyKLJQpqadwju7uL13qX7qHXZNqRQ50bTM8txY6Rd
         7cVbCgoWW77chRT3zHYdb2j1T4kfvPJ436CCyQHW2sDMSwPzQfWaXbqvzlRUA9oLMckP
         1KKweQlMeCXCR6O0Ucn3wClbfON0PizEAZTOThd7+NCy/Rdp2aUPy4qyUBy30zJfmW/+
         KDUHAkO2c1ga2djNIrnDrtrnDEF+P/Y9+dM5gSZ/EB4PLs22uquR+jfcT7SuB9TPRR6g
         EG3dJQtFmxjsRpBNEswxGd9UBQO59W6b6QaVsOZZ/YehEioWGu/GPSerwsoloCyismHO
         ZyFA==
X-Gm-Message-State: AOAM5323jr/tP+sxiGNZKBP3/VG2DO8jbZgKtfmCQ7GMbCaU7rAFrlq4
	/a55mzE8HA14N+dINBE2wexN+Mg5AW4rdYi+zmE=
X-Google-Smtp-Source: ABdhPJyr9Xl3pS0jI7WRjc8AhgXLdZ5xwnsY79oStcLNTveNYz1eEorTfQPuyzOcs00wzHG+mufuFA==
X-Received: by 2002:a17:902:9683:b029:de:b0ba:dc86 with SMTP id n3-20020a1709029683b02900deb0badc86mr9488286plp.9.1611140224418;
        Wed, 20 Jan 2021 02:57:04 -0800 (PST)
Return-Path: <mforney@mforney.org>
Received: from arrow.hsd1.ca.comcast.net (c-73-70-188-119.hsd1.ca.comcast.net. [73.70.188.119])
        by smtp.gmail.com with ESMTPSA id m10sm2020985pjn.53.2021.01.20.02.57.03
        for <9front@9front.org>
        (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256);
        Wed, 20 Jan 2021 02:57:03 -0800 (PST)
Message-ID: <9ECB0CAF455CBF181F28D3BDE6ED5D35@arrow.hsd1.ca.comcast.net>
To: 9front@9front.org
From: Michael Forney <mforney@mforney.org>
Date: Wed, 20 Jan 2021 02:57:02 -0800
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: leveraged abstract NoSQL-based dependency browser 
Subject: [9front] cc: remove unnecessary 128-bit add function
Reply-To: 9front@9front.org
Precedence: bulk

Instead, just change the comparisons from <=/>= to </>.

diff -r 11c719e3c471 -r de216620e3ab sys/src/cmd/cc/com.c
--- a/sys/src/cmd/cc/com.c	Wed Jan 20 01:29:03 2021 -0800
+++ b/sys/src/cmd/cc/com.c	Wed Jan 20 01:38:46 2021 -0800
@@ -1360,19 +1360,6 @@
 	}
 	return 0;
 }
-static Big
-add(Big x, int y)
-{
-	uvlong ob;
-	
-	ob = x.b;
-	x.b += y;
-	if(y > 0 && x.b < ob)
-		x.a++;
-	if(y < 0 && x.b > ob)
-		x.a--;
-	return x;
-} 
 
 Big
 big(vlong a, uvlong b)
@@ -1468,14 +1455,14 @@
 	case OHS:
 		if(cmp(x, lo) <= 0)
 			goto useless;
-		if(cmp(x, add(hi, 1)) >= 0)
+		if(cmp(x, hi) > 0)
 			goto useless;
 		break;
 	case OLE:
 	case OLS:
 	case OGT:
 	case OHI:
-		if(cmp(x, add(lo, -1)) <= 0)
+		if(cmp(x, lo) < 0)
 			goto useless;
 		if(cmp(x, hi) >= 0)
 			goto useless;