From: unobe@cpan.org
To: 9front@9front.org
Subject: Re: [9front] exportfs: fix debug logging
Date: Thu, 12 Aug 2021 23:46:31 -0700 [thread overview]
Message-ID: <A38F288BD5DE7D67681A84CA07ECA66B@smtp.pobox.com> (raw)
Quoth Amavect <amavect@gmail.com>:
> All,
>
> Exportfs -d might not be able to create the debug file without
> permission. Instead of letting execution continue, patch 1 makes it
> fail.
> ...
> --- //.git/fs/object/bf6769d3f09d51ff1096afa664c10d3313341a75/tree/sys/src/cmd/exportfs/exportfs.c
> +++ sys/src/cmd/exportfs/exportfs.c
> @@ -19,12 +19,12 @@
> main(int argc, char **argv)
> {
> char *dbfile, *srv, *srvfdfile;
> - int n;
>
> dbfile = "/tmp/exportdb";
> srv = nil;
> srvfd = -1;
> srvfdfile = nil;
> + int n;
>
> ARGBEGIN{
> case 'd':
I know you already created a different patch, but this part of the
patch looks pointless, but I don't program in C a lot so maybe I can
learn something new. I thought declarations generally go together, so
why move this one declaration down to after initializations?
next reply other threads:[~2021-08-13 7:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 6:46 unobe [this message]
2021-08-13 11:15 ` Amavect
2021-08-14 20:14 ` Stuart Morrow
2021-08-15 16:40 ` kvik
2021-08-15 20:44 ` Stuart Morrow
2021-08-16 20:17 ` Humm
-- strict thread matches above, loose matches on Subject: below --
2021-08-13 1:11 Amavect
2021-08-13 19:11 ` ori
2021-08-14 22:04 ` Amavect
2021-08-15 16:29 ` kvik
2021-08-16 4:40 ` unobe
2021-08-16 5:20 ` ori
2021-08-16 16:49 ` unobe
2021-08-16 13:55 ` kvik
2021-08-16 16:50 ` unobe
2021-08-16 17:56 ` Amavect
2021-08-16 19:32 ` ori
2021-08-16 22:48 ` ori
2021-08-18 14:24 ` cinap_lenrek
2021-08-18 14:49 ` k m
2021-08-16 20:19 ` Steve Simon
2021-08-16 23:26 ` ori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A38F288BD5DE7D67681A84CA07ECA66B@smtp.pobox.com \
--to=unobe@cpan.org \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).