From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 15685 invoked from network); 13 Aug 2021 07:17:38 -0000 Received: from 1ess.inri.net (216.126.196.35) by inbox.vuxu.org with ESMTPUTF8; 13 Aug 2021 07:17:38 -0000 Received: from pb-smtp2.pobox.com ([64.147.108.71]) by 1ess; Fri Aug 13 02:54:19 -0400 2021 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 876F7E1E55 for <9front@9front.org>; Fri, 13 Aug 2021 02:46:33 -0400 (EDT) (envelope-from unobe@cpan.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=message-id :to:subject:date:from:mime-version:content-type :content-transfer-encoding; s=sasl; bh=+d5i/pshA2v2zfxsZi9PZriUu DVGjAWsG5f5mEQd5sc=; b=crmsGuLeg8ksrKCf2TtmX5zdDg7VfdBxfNJTgkF0T vIFBPyFdeuJ31c9Fu62l6mZISClBv45BjxEfPEtwTaR1Ysb2ObxeQeDNKMXqe2wC 3lVn7BmCN2zf47dAdWgtX2kHksJ6rTaIj4s7shoeT0Fi2BHO6JpVBp0Ej59HNaEC 6s= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 803E3E1E54 for <9front@9front.org>; Fri, 13 Aug 2021 02:46:33 -0400 (EDT) (envelope-from unobe@cpan.org) Received: from strider (unknown [47.34.135.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id C6D4EE1E53 for <9front@9front.org>; Fri, 13 Aug 2021 02:46:32 -0400 (EDT) (envelope-from unobe@cpan.org) Message-ID: To: 9front@9front.org Date: Thu, 12 Aug 2021 23:46:31 -0700 From: unobe@cpan.org MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Pobox-Relay-ID: 325045CE-FC02-11EB-A6E2-FD8818BA3BAF-09620299!pb-smtp2.pobox.com List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: blockchain STM-based database Subject: Re: [9front] exportfs: fix debug logging Reply-To: 9front@9front.org Precedence: bulk Quoth Amavect : > All, > > Exportfs -d might not be able to create the debug file without > permission. Instead of letting execution continue, patch 1 makes it > fail. > ... > --- //.git/fs/object/bf6769d3f09d51ff1096afa664c10d3313341a75/tree/sys/src/cmd/exportfs/exportfs.c > +++ sys/src/cmd/exportfs/exportfs.c > @@ -19,12 +19,12 @@ > main(int argc, char **argv) > { > char *dbfile, *srv, *srvfdfile; > - int n; > > dbfile = "/tmp/exportdb"; > srv = nil; > srvfd = -1; > srvfdfile = nil; > + int n; > > ARGBEGIN{ > case 'd': I know you already created a different patch, but this part of the patch looks pointless, but I don't program in C a lot so maybe I can learn something new. I thought declarations generally go together, so why move this one declaration down to after initializations?